From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41493) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1URhDk-0002Hf-4e for qemu-devel@nongnu.org; Mon, 15 Apr 2013 07:05:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1URhDi-00050d-HF for qemu-devel@nongnu.org; Mon, 15 Apr 2013 07:05:12 -0400 Received: from mail-pa0-f46.google.com ([209.85.220.46]:46241) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1URh1n-00007m-15 for qemu-devel@nongnu.org; Mon, 15 Apr 2013 06:52:51 -0400 Received: by mail-pa0-f46.google.com with SMTP id lb1so2504447pab.19 for ; Mon, 15 Apr 2013 03:52:49 -0700 (PDT) Message-ID: <516BDBFB.5070602@ozlabs.ru> Date: Mon, 15 Apr 2013 20:52:43 +1000 From: Alexey Kardashevskiy MIME-Version: 1.0 References: <1365993073-4659-1-git-send-email-aik@ozlabs.ru> <8761zofezy.fsf@blackfin.pond.sub.org> <516BA87A.2020107@ozlabs.ru> <874nf8cidj.fsf@blackfin.pond.sub.org> <516BCD71.9070905@ozlabs.ru> In-Reply-To: Content-Type: text/plain; charset=KOI8-R; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] pixman: remove -Wredundand-decls List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Markus Armbruster , qemu-devel@nongnu.org, Blue Swirl , Gerd Hoffmann , Stefan Hajnoczi , David Gibson On 04/15/2013 08:01 PM, Peter Maydell wrote: > On 15 April 2013 10:50, Alexey Kardashevskiy wrote: >> /home/alexey/pcipassthru/qemu-impreza/../lib4qemu/usr/include/assert.h:67:13: >> error: redundant redeclaration of '__assert_fail' [-Werror=redundant-decls] >> /home/alexey/pcipassthru/qemu-impreza/../lib4qemu/usr/include/assert.h:67:13: >> note: previous declaration of '__assert_fail' was here >> /home/alexey/pcipassthru/qemu-impreza/../lib4qemu/usr/include/assert.h:72:13: >> error: redundant redeclaration of '__assert_perror_fail' >> [-Werror=redundant-decls] > > This copy of assert.h seems to be broken. The declarations > should be guarded (by _ASSERT_H_DECLS in my system's copy). Debian? It uses eglibc which is fork (or clone?) of glibc. > If it's widespread we might have to work around this. It is in fedora 18 and glibc's git master branch. Why "if"? And this is not it. I just managed to suppress others with -Wredundand-decls, like the one with strtold() defined twice in /usr/include/stdlib.h and /usr/include/bits/stdlib-ldbl.h and some others. I suspect I am getting these errors because I am the only person who is trying to cross compile or/and when host and target endianness differ. Does anyone do cross compilation (with different endianness?) on a regular basis? My colleagues do not :) >> If we disable that warning, I do not what we loose. The "bug" above is not a >> bug at all. > > What we lose is that we are no longer informed when people > inadvertently introduce redundant declarations into QEMU itself. -- Alexey