From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:38934)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1URh71-0006JN-Od
	for qemu-devel@nongnu.org; Mon, 15 Apr 2013 06:58:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1URh6y-0001wB-Kf
	for qemu-devel@nongnu.org; Mon, 15 Apr 2013 06:58:15 -0400
Received: from mx1.redhat.com ([209.132.183.28]:36662)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1URh6y-0001vp-Cf
	for qemu-devel@nongnu.org; Mon, 15 Apr 2013 06:58:12 -0400
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r3FAwBWf028486
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Mon, 15 Apr 2013 06:58:11 -0400
Message-ID: <516BDDCA.6010707@redhat.com>
Date: Mon, 15 Apr 2013 13:00:26 +0200
From: Laszlo Ersek <lersek@redhat.com>
MIME-Version: 1.0
References: <cover.1366018642.git.mst@redhat.com>
	<5899f1a3f5671520e17a6a3779c6defa5ae4a6e9.1366018642.git.mst@redhat.com>
	<516BD9A4.2050307@redhat.com>
In-Reply-To: <516BD9A4.2050307@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/3] acpi: move declarations from pc.h to
 acpi.h
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org

On 04/15/13 12:42, Paolo Bonzini wrote:
> Il 15/04/2013 11:37, Michael S. Tsirkin ha scritto:
>> +/* acpi.c */
>> +extern int acpi_enabled;
>> +extern char unsigned *acpi_tables;
>> +extern size_t acpi_tables_len;
>> +
>> +void acpi_table_install(const char unsigned *blob, size_t bloblen,
>> +                        bool has_header, const struct AcpiTableOptions *hdrs,
>> +                        Error **errp);
> 
> This function is static, I've fixed it up and will include it in the hw/
> fixups pull request.
> 
> I picked up patch 3 as well, I'll leave 2 to Laszlo.
> 
> Paolo
> 
>> +void acpi_table_add(const QemuOpts *opts, Error **errp);

Doesn't this series conflict with my pending
<http://lists.nongnu.org/archive/html/qemu-devel/2013-04/msg01427.html>?

Thanks
Laszlo