From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:48051) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1URiwQ-0006Or-1c for qemu-devel@nongnu.org; Mon, 15 Apr 2013 08:55:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1URiwN-0008NY-HP for qemu-devel@nongnu.org; Mon, 15 Apr 2013 08:55:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43325) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1URiwN-0008ND-AF for qemu-devel@nongnu.org; Mon, 15 Apr 2013 08:55:23 -0400 Message-ID: <516BF8B1.4010605@redhat.com> Date: Mon, 15 Apr 2013 14:55:13 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1366027532-1120-1-git-send-email-pbonzini@redhat.com> <1366027532-1120-2-git-send-email-pbonzini@redhat.com> <516BF073.9060609@suse.de> In-Reply-To: <516BF073.9060609@suse.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH uq/master v3 1/2] kvm: reset state from the CPU's reset method List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-15?Q?Andreas_F=E4rber?= Cc: gnatapov@redhat.com, qemu-devel@nongnu.org, agraf@suse.de Il 15/04/2013 14:20, Andreas F=E4rber ha scritto: > Fine with me. >=20 > Have you tested whether i386 needs a similar stub on non-x86? If so the= n >=20 > Reviewed-by: Andreas F=E4rber It doesn't need it, because the prototype is declared always in kvm_i386.= h. I didn't test non-x86, but I tested an alternative patches that places s390's kvm_arch_reset_vcpu prototype outside "#ifdef CONFIG_KVM". That also compiled fine on non-s390, and it's what will happen when compiling on non-x86. I figured that the dummy inline definition was closer in style to the existing s390 code, so that's what I chose for submission. Paolo