From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:34069)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1URjT7-0002AP-Q3
	for qemu-devel@nongnu.org; Mon, 15 Apr 2013 09:29:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1URjT4-0005XZ-TO
	for qemu-devel@nongnu.org; Mon, 15 Apr 2013 09:29:13 -0400
Received: from mx1.redhat.com ([209.132.183.28]:2050)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1URjT4-0005X5-MJ
	for qemu-devel@nongnu.org; Mon, 15 Apr 2013 09:29:10 -0400
Message-ID: <516C012D.20508@redhat.com>
Date: Mon, 15 Apr 2013 15:31:25 +0200
From: Laszlo Ersek <lersek@redhat.com>
MIME-Version: 1.0
References: <cover.1366018642.git.mst@redhat.com>
	<20130415112534.GA18459@redhat.com> <516BFF70.8050907@redhat.com>
In-Reply-To: <516BFF70.8050907@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 0/3] acpi: more infrastructure cleanups
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org

On 04/15/13 15:24, Laszlo Ersek wrote:

> Second, 2/3 breaks the binary format exported under the
> FW_CFG_ACPI_TABLES key. The format is as follows:
> 
>   * number of tables in entire fw_cfg blob : uint16_t
>   for each table:
>     * ACPI payload size belonging to this table : uint16_t
>     * standard ACPI header
>     * ACPI table contents
> 
> whereas 2/3 changes the format to:
> 
>   * zero-filled uint16_t (i)
>   for each table:
>     * uint16_t storing value 1 in LE order (ii)
>     * number of bytes in blob segment belonging to this table : uint16_t

Sorry, this was mis-editing the email on my part: the _length field is
computed alright, it's only the (i)<->(ii) thing that goes wrong.

>     * standard ACPI header
>     * ACPI table contents
> 
> (ii) shouldn't exist in per-table storage, the increments should target
> (i) actually.

Laszlo