From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56020) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1URkTg-0005Yp-B1 for qemu-devel@nongnu.org; Mon, 15 Apr 2013 10:33:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1URkTb-0006Mv-9F for qemu-devel@nongnu.org; Mon, 15 Apr 2013 10:33:52 -0400 Received: from greensocs.com ([87.106.252.221]:50448 helo=s15328186.onlinehome-server.info) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1URkTb-0006Mr-3R for qemu-devel@nongnu.org; Mon, 15 Apr 2013 10:33:47 -0400 Message-ID: <516C0FC7.8070500@greensocs.com> Date: Mon, 15 Apr 2013 16:33:43 +0200 From: =?ISO-8859-15?Q?KONRAD_Fr=E9d=E9ric?= MIME-Version: 1.0 References: <1365944470-13837-1-git-send-email-fred.konrad@greensocs.com> <1365944470-13837-9-git-send-email-fred.konrad@greensocs.com> <516C01DE.6070309@suse.de> In-Reply-To: <516C01DE.6070309@suse.de> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3 8/8] virtio-rng: cleanup: use QOM casts. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-15?Q?Andreas_F=E4rber?= Cc: peter.maydell@linaro.org, aliguori@us.ibm.com, mark.burton@greensocs.com, qemu-devel@nongnu.org, cornelia.huck@de.ibm.com, amit.shah@redhat.com On 15/04/2013 15:34, Andreas F=E4rber wrote: > Am 14.04.2013 15:01, schrieb fred.konrad@greensocs.com: >> From: KONRAD Frederic >> >> As the virtio-rng-pci and virtio-rng-s390 are switched to the new API, > and virtio-rng-ccw ;) > >> we can use QOM casts. >> >> Signed-off-by: KONRAD Frederic >> --- >> hw/virtio/virtio-rng.c | 31 +++++++++++++++++-------------- >> include/hw/virtio/virtio-rng.h | 2 +- >> 2 files changed, 18 insertions(+), 15 deletions(-) > Thanks, > > Reviewed-by: Andreas F=E4rber > > I was surprised to see FOO(opaque) since we usually try to avoid it for > performance reasons, but it's not forbidden either. True, I had taken that in account but forget this series :/. Is it better to change that? Thanks, Fred > Also, leaving the variable name as "s" would've spared a few lines but > so what. :) > > Regards, > Andreas >