From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55821) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1URlvd-0006u2-NE for qemu-devel@nongnu.org; Mon, 15 Apr 2013 12:06:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1URlvW-0001qx-LJ for qemu-devel@nongnu.org; Mon, 15 Apr 2013 12:06:49 -0400 Received: from cantor2.suse.de ([195.135.220.15]:52279 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1URlvW-0001qW-GM for qemu-devel@nongnu.org; Mon, 15 Apr 2013 12:06:42 -0400 Message-ID: <516C2590.8060903@suse.de> Date: Mon, 15 Apr 2013 18:06:40 +0200 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1365691918-30594-1-git-send-email-imammedo@redhat.com> <1365691918-30594-14-git-send-email-imammedo@redhat.com> <516C1F0B.6070403@suse.de> <20130415174939.0f3816e6@nial.usersys.redhat.com> In-Reply-To: <20130415174939.0f3816e6@nial.usersys.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 13/19] target-i386: cpu: attach ICC bus to CPU on its creation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: aliguori@us.ibm.com, ehabkost@redhat.com, claudio.fontana@huawei.com, qemu-devel@nongnu.org, aderumier@odiso.com, lcapitulino@redhat.com, jfrei@linux.vnet.ibm.com, yang.z.zhang@intel.com, Paolo Bonzini , lig.fnst@cn.fujitsu.com, rth@twiddle.net Am 15.04.2013 17:49, schrieb Igor Mammedov: > On Mon, 15 Apr 2013 17:38:51 +0200 > Andreas F=E4rber wrote: >=20 >> Am 11.04.2013 16:51, schrieb Igor Mammedov: >>> ... during startup, so it would be possible to uplug it later >> >> unplug? > CPU won't be unplug-able if it's not on ICC bus. Sorry? Question was whether "uplug" is a typo and should read "unplug"? On openSUSE 12.3 there is no command called uplug. :) >>> and set bus_type to TYPE_ICC_BUS for X86CPU type to make device_add >>> attach hotplugged CPU to ICC bus. >>> >>> Signed-off-by: Igor Mammedov >>> --- >>> target-i386/cpu.c | 7 +++++++ >>> 1 file changed, 7 insertions(+) >>> >>> diff --git a/target-i386/cpu.c b/target-i386/cpu.c >>> index 4ddc18a..2bb38d6 100644 >>> --- a/target-i386/cpu.c >>> +++ b/target-i386/cpu.c [...] >>> @@ -1620,6 +1622,10 @@ X86CPU *cpu_x86_create(const char *cpu_model, >>> Error **errp) features =3D model_pieces[1]; >>> =20 >>> cpu =3D X86_CPU(object_new(TYPE_X86_CPU)); >>> + if (icc_bus) { >>> + qdev_set_parent_bus(DEVICE(cpu), BUS(icc_bus)); >>> + object_unref(OBJECT(cpu)); >> >> Why are you unref'ing here? (Paolo?) >=20 > To leave only one reference to it since qdev_set_parent_bus() just > incremented it. Like it's done in qdev_try_create(). Ah, I see, thanks. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg