From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54841) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1URnR0-0004XI-SX for qemu-devel@nongnu.org; Mon, 15 Apr 2013 13:43:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1URnQu-00051t-QC for qemu-devel@nongnu.org; Mon, 15 Apr 2013 13:43:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:12784) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1URnQu-00051j-Er for qemu-devel@nongnu.org; Mon, 15 Apr 2013 13:43:12 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r3FHhBZe032527 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 15 Apr 2013 13:43:11 -0400 Message-ID: <516C3C2E.9060005@redhat.com> Date: Mon, 15 Apr 2013 11:43:10 -0600 From: Eric Blake MIME-Version: 1.0 References: <1365799688-19918-1-git-send-email-kwolf@redhat.com> <1365799688-19918-4-git-send-email-kwolf@redhat.com> In-Reply-To: <1365799688-19918-4-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2ILRCCSBWGQXCIAXWPKKJ" Subject: Re: [Qemu-devel] [PATCH 03/15] block: Enable filename option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2ILRCCSBWGQXCIAXWPKKJ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 04/12/2013 02:47 PM, Kevin Wolf wrote: > This allows using the file.filename option instead of the string that > comes from -drive file=3D... and is passed around as a separate paramet= er. > The goal is to get rid of this parameter and use the options QDict more= > consistently. >=20 > With this option you can access not only the top-level image, but > specify a filename for the backing file (currently only if no backing > file exists, but we'll allow overriding it later) >=20 > Signed-off-by: Kevin Wolf > --- > block.c | 31 +++++++++++++++++++++++++++---- > 1 file changed, 27 insertions(+), 4 deletions(-) Quite a few lines added for a net reduction in parameters, but the results look nice. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2ILRCCSBWGQXCIAXWPKKJ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRbDwuAAoJEKeha0olJ0Nq/ccH/RupTAc5rjMrr5fPukUjJ294 FaOrLGlYZAkgsTs7oaFmVpc2CliqQCdVg07LL7/PAObYR0qhN9nFhZCEQaiMO/3/ Wot7CwjfDztskNQP3Y/SFZbJ+ptKAfOjQD9mTAtimSIO6TSX10RbWUk1k8hAeEwu RqQ3dNBmdYVp3C1Zskuh+E887MrN9HieR78gP+ib+j3HjBx/EAE8RaTOgcT374kd XHYgYGUGI8vQlYs+M5jYSciP6yLeUTREM1pAsQhI35uLbd0l70RddPjscoS/XqA2 MRWsHJsfxMbZftB0e5b7gkblZ134BLD/cyUJUG9CI0/Pz7HQZJ/cK56cNlmmE4c= =YiTT -----END PGP SIGNATURE----- ------enig2ILRCCSBWGQXCIAXWPKKJ--