From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56774) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1URnZu-00048h-88 for qemu-devel@nongnu.org; Mon, 15 Apr 2013 13:52:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1URnZs-0008WD-Px for qemu-devel@nongnu.org; Mon, 15 Apr 2013 13:52:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:4238) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1URnZs-0008W8-Gq for qemu-devel@nongnu.org; Mon, 15 Apr 2013 13:52:28 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r3FHqROj013911 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 15 Apr 2013 13:52:27 -0400 Message-ID: <516C3E5A.3070309@redhat.com> Date: Mon, 15 Apr 2013 11:52:26 -0600 From: Eric Blake MIME-Version: 1.0 References: <1365799688-19918-1-git-send-email-kwolf@redhat.com> <1365799688-19918-5-git-send-email-kwolf@redhat.com> In-Reply-To: <1365799688-19918-5-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2IJAJWDLIAQCBCAKVXDLI" Subject: Re: [Qemu-devel] [PATCH 04/15] raw-posix: Use bdrv_open options instead of filename List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2IJAJWDLIAQCBCAKVXDLI Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 04/12/2013 02:47 PM, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > block/raw-posix.c | 57 +++++++++++++++++++++++++++++++++++++++++++----= -------- > 1 file changed, 45 insertions(+), 12 deletions(-) > +static int raw_open_common(BlockDriverState *bs, QDict *options, > int bdrv_flags, int open_flags) > { > BDRVRawState *s =3D bs->opaque; > + QemuOpts *opts; > + Error *local_err =3D NULL; > + const char* filename; Spacing is off for this line (should be before *, not after). But that's trivial, so I have no qualms with adding this to a fixed version: Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2IJAJWDLIAQCBCAKVXDLI Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRbD5aAAoJEKeha0olJ0NqFPQH/1c4VzSgSGBezBqU6oan1fml Gg15HlRfFj8w2qw8e97oR9bzrpFvY2k7c7Nx/6qXxRM+hd0qoKd+AMfrS77/mdHP tEHgzmqoTApLZllkdci5ZlGINAvSO1yJgtunyvjbMsyYAXNS9KZNDDuC6SYQj9xD MVZKbgNELAzbbq9HZj/uLb+lihm05AQwynhhcQkQ+vUD0e7ViO2X8NIe8YOjwl9f PjU7Q1fzqmhGacBrCHjdnl+WxJpC1XR5uaVTCeqyJczX0HMyR4zdcR9bn+oqUFsT /moWd1XUvaWTYclMPfXKD/KhwT+4oILnR9QPYYpYj6nCiN8vfnqu73Cziw390GA= =B3x6 -----END PGP SIGNATURE----- ------enig2IJAJWDLIAQCBCAKVXDLI--