From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51634) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1URotP-0005bS-HM for qemu-devel@nongnu.org; Mon, 15 Apr 2013 15:16:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1URotO-00077d-CF for qemu-devel@nongnu.org; Mon, 15 Apr 2013 15:16:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:26352) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1URotO-00077U-4B for qemu-devel@nongnu.org; Mon, 15 Apr 2013 15:16:42 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r3FJGfwl003796 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 15 Apr 2013 15:16:41 -0400 Message-ID: <516C5218.2070300@redhat.com> Date: Mon, 15 Apr 2013 13:16:40 -0600 From: Eric Blake MIME-Version: 1.0 References: <1365799688-19918-1-git-send-email-kwolf@redhat.com> <1365799688-19918-6-git-send-email-kwolf@redhat.com> In-Reply-To: <1365799688-19918-6-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2SJAICKQWEXFEADSJKFBL" Subject: Re: [Qemu-devel] [PATCH 05/15] raw-win32: Use bdrv_open options instead of filename List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2SJAICKQWEXFEADSJKFBL Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 04/12/2013 02:47 PM, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > block/raw-win32.c | 57 +++++++++++++++++++++++++++++++++++++++++++++--= -------- > 1 file changed, 47 insertions(+), 10 deletions(-) >=20 > +static int raw_open(BlockDriverState *bs, const char *unused, > QDict *options, int flags) > { > BDRVRawState *s =3D bs->opaque; > int access_flags; > DWORD overlapped; > + QemuOpts *opts; > + Error *local_err =3D NULL; > + const char* filename; Copy-and-paste formatting of this line from 4/15. Same caveat about it being trivial enough to add this once fixed: Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2SJAICKQWEXFEADSJKFBL Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRbFIYAAoJEKeha0olJ0Nq6gkH/1uj9CuUCnZQqwEljnIfIMMw Y5rCd6n4Yx4i/cseMDs2gZKMRsuP9KuC2IJsmSQjPmq22gjyD3u277MfOYUXqkG/ k8guDmvdaEhrblwBR7hcCcTashS95AKhaNHR4vDrxk3TAxf+BM5R72JvXu8yZnxy 0nPA5IcKwGzeJGAa/SKOM5Eh5i8V45piQjgxICC8eGapdQjsLRr4ZVO3VgD7u33j 50D5pcJ/oomjEwSzBHYc+2ZLHJ6ycHRyR5YxRo32sTZjABuC4Am7pwR1Fykp5Vg1 yUFUvVnHonVtOE6Ew/pI8a3MFNrjmvebGlKPl9cEkhD9CSYbbyGZhFU24IqK/5I= =VZmc -----END PGP SIGNATURE----- ------enig2SJAICKQWEXFEADSJKFBL--