From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60427) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1URpNg-0008Ew-5j for qemu-devel@nongnu.org; Mon, 15 Apr 2013 15:48:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1URpNf-0001ma-4H for qemu-devel@nongnu.org; Mon, 15 Apr 2013 15:48:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:21149) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1URpNe-0001mT-Rr for qemu-devel@nongnu.org; Mon, 15 Apr 2013 15:47:59 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r3FJlwXi015456 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 15 Apr 2013 15:47:58 -0400 Message-ID: <516C596D.9010902@redhat.com> Date: Mon, 15 Apr 2013 13:47:57 -0600 From: Eric Blake MIME-Version: 1.0 References: <1365799688-19918-1-git-send-email-kwolf@redhat.com> <1365799688-19918-8-git-send-email-kwolf@redhat.com> In-Reply-To: <1365799688-19918-8-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2SXOVFOUTQIVVMGOEXKTP" Subject: Re: [Qemu-devel] [PATCH 07/15] blkverify: Use bdrv_open options instead of filename List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2SXOVFOUTQIVVMGOEXKTP Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 04/12/2013 02:48 PM, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > block/blkverify.c | 94 ++++++++++++++++++++++++++++++++++++++++++++---= -------- > 1 file changed, 76 insertions(+), 18 deletions(-) >=20 > /* Parse the blkverify: prefix */ > - if (strncmp(filename, "blkverify:", strlen("blkverify:"))) { > - return -EINVAL; > + if (!strstart(filename, "blkverify:", &filename)) { > + error_setg(errp, "File name string must start with 'blkverify:= '"); > + return; > } > - filename +=3D strlen("blkverify:"); > =20 > /* Parse the raw image filename */ > c =3D strchr(filename, ':'); > if (c =3D=3D NULL) { > - return -EINVAL; > + error_setg(errp, "blkdebug requires raw copy and original imag= e path"); s/blkdebug/blkverify/ Simple enough fix that I'm still comfortable if you include: Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2SXOVFOUTQIVVMGOEXKTP Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRbFltAAoJEKeha0olJ0Nq7ncH/RpXZnlL9qQqkaxqCYYNUKF6 f6qjQ8G+4eR/l7pOwFsTeey24srbgWGxJlXUW5uQuBngBR3gCO64wmOoJCycLlrn Tt8Y6uymoQbBuJOd6xZtu92meMWUubv1N3v4oK5ZxcqkX43muXeHRr5Mo9aPD5LS q2Yu9n/lUVB4bpKDt/73Cf37M6TAUXB2fzf8cpc29nZaRZQ3CpV6wtOWI7lHeont /BMfiwzJon2+5LF+F204X3swaG5kMS4vpMJydsw6/Urr/lAe/PqJAMAqOMEFXtKD o0EvZ9+m6kqzXTRSAzQvkgUO516e3PI+xb5kRDHw4xvmYlJ3PMH4HMxQ56asbK8= =UT9S -----END PGP SIGNATURE----- ------enig2SXOVFOUTQIVVMGOEXKTP--