From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36552) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1URpgU-00029e-09 for qemu-devel@nongnu.org; Mon, 15 Apr 2013 16:07:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1URpgS-0000AE-Mh for qemu-devel@nongnu.org; Mon, 15 Apr 2013 16:07:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:20592) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1URpgS-00009r-Dy for qemu-devel@nongnu.org; Mon, 15 Apr 2013 16:07:24 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r3FK7Nv9028606 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 15 Apr 2013 16:07:24 -0400 Message-ID: <516C5DFA.6070906@redhat.com> Date: Mon, 15 Apr 2013 14:07:22 -0600 From: Eric Blake MIME-Version: 1.0 References: <1365799688-19918-1-git-send-email-kwolf@redhat.com> <1365799688-19918-10-git-send-email-kwolf@redhat.com> In-Reply-To: <1365799688-19918-10-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2RCCHLAENPVTLHEQQPLTJ" Subject: Re: [Qemu-devel] [PATCH 09/15] gluster: Use bdrv_open options instead of filename List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2RCCHLAENPVTLHEQQPLTJ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 04/12/2013 02:48 PM, Kevin Wolf wrote: > This is only to convert the internal interface that is used for passing= > the "filename" to be parsed, but converting to actual fine grained > options is left for another day, as it doesn't look trivial. >=20 > Signed-off-by: Kevin Wolf > --- > block/gluster.c | 32 +++++++++++++++++++++++++++++++- > 1 file changed, 31 insertions(+), 1 deletion(-) >=20 > + > +static int qemu_gluster_open(BlockDriverState *bs, const char *dummy, > QDict *options, int bdrv_flags) As long as you are touching this code, should you re-indent the second line of this signature? > + > + filename =3D qemu_opt_get(opts, "filename"); > + > =20 > s->glfs =3D qemu_gluster_init(gconf, filename); Why the two blank lines? Comments deal only with whitespace, so feel free to add: Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2RCCHLAENPVTLHEQQPLTJ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRbF36AAoJEKeha0olJ0Nq850IAKfF14eXhnKW8lBN5pI5R4XR ezktxI6vCrnsixUlbK3RZvQcTlRtrTPOeEAGn6vBnxQu+eiujz02zuJ/aG91Q4sb ST+/JZXb1hfJGTdz3Hi7XpzEk8TOGzKa9r7tNgxtqQtAC3cSZqagFzlk5e2imntL il1aqb7Kz4RLQrLoonV9YMQ8LJh5X3CEldZ2vhhQN6GaVlsInisLZeAE/ZA6SWp6 lNHk0Ta5Y20Ts3u/Vn9gRST14qy8233QY5acXvepf6QL7rdJLzKGcknRwp/JmsiA tg/BO8oRj5XEq4ff6pQKmDfZBlpV5VywMCkDQLcfW2Ac0UYOamuMx7UT0P7P0Tw= =GLv8 -----END PGP SIGNATURE----- ------enig2RCCHLAENPVTLHEQQPLTJ--