From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45358) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1URqJ3-0006u2-DB for qemu-devel@nongnu.org; Mon, 15 Apr 2013 16:47:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1URqJ2-0005An-1g for qemu-devel@nongnu.org; Mon, 15 Apr 2013 16:47:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:7286) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1URqJ1-00059d-O9 for qemu-devel@nongnu.org; Mon, 15 Apr 2013 16:47:15 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r3FKlFdn011964 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 15 Apr 2013 16:47:15 -0400 Message-ID: <516C6751.6050500@redhat.com> Date: Mon, 15 Apr 2013 14:47:13 -0600 From: Eric Blake MIME-Version: 1.0 References: <1365799688-19918-1-git-send-email-kwolf@redhat.com> <1365799688-19918-15-git-send-email-kwolf@redhat.com> In-Reply-To: <1365799688-19918-15-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2WWQHSVODHRLQIIVFEQFQ" Subject: Re: [Qemu-devel] [PATCH 14/15] block: Remove filename parameter from .bdrv_file_open() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2WWQHSVODHRLQIIVFEQFQ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 04/12/2013 02:48 PM, Kevin Wolf wrote: > It is unused now in all block drivers. >=20 > Signed-off-by: Kevin Wolf > --- > +++ b/block/gluster.c > @@ -296,8 +296,8 @@ static QemuOptsList runtime_opts =3D { > }, > }; > =20 > -static int qemu_gluster_open(BlockDriverState *bs, const char *dummy, > - QDict *options, int bdrv_flags) > +static int qemu_gluster_open(BlockDriverState *bs, QDict *options, > + int bdrv_flags) Ah, one of my comments about inconsistent indentation in 9/15 has been solved here (so it's fine to avoid the churn of touching it up twice). Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2WWQHSVODHRLQIIVFEQFQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRbGdRAAoJEKeha0olJ0NqlnUIAJSQ6D5XvLHVQMR8XA1HrpcC TfbgWFqtOAAz/Tm0mTCOXTI1Gohtv7MAZOCCxsm6TZQX0ySovWJGpcT0LHTuDvYu vUPxtvRDybd7pyXZUCaE+Krjyf1QIYpbooJGIv4VSuKrdFjmja7IGBJm2tmb1k0X kPg6pyyq6bal2EfQBSoXArBARKLGts1AQZ5zRHZeZ/LwseWldUZYu7SQza2Wp2YA 9pOAU4EHi3FWRDfNpijE81WbJUZgPmXKfAOQKRaG4REzhkc/DhWR2W7q2w/ttL5W Ft655rkIeL/6CTb8QxYfC3skZqagJmvLWGHthg/oO+iEYciE6/REkqvDR8TOF9Q= =jCM2 -----END PGP SIGNATURE----- ------enig2WWQHSVODHRLQIIVFEQFQ--