From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51188) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1URqg4-0005rB-OL for qemu-devel@nongnu.org; Mon, 15 Apr 2013 17:11:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1URqg3-0004pO-Fq for qemu-devel@nongnu.org; Mon, 15 Apr 2013 17:11:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:20013) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1URqg3-0004pG-39 for qemu-devel@nongnu.org; Mon, 15 Apr 2013 17:11:03 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r3FLB2re009947 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 15 Apr 2013 17:11:02 -0400 Message-ID: <516C6CE5.7020901@redhat.com> Date: Mon, 15 Apr 2013 15:11:01 -0600 From: Eric Blake MIME-Version: 1.0 References: <1366058872-11196-1-git-send-email-lersek@redhat.com> <1366058872-11196-8-git-send-email-lersek@redhat.com> In-Reply-To: <1366058872-11196-8-git-send-email-lersek@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2PXQGMTUWTGONWTXSKDCB" Subject: Re: [Qemu-devel] [PATCH v2 7/7] hw/i386: build ACPI MADT (APIC) for fw_cfg clients List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek Cc: qemu-devel@nongnu.org, mst@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2PXQGMTUWTGONWTXSKDCB Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 04/15/2013 02:47 PM, Laszlo Ersek wrote: > This patch reuses some code from SeaBIOS, which was originally under > LGPLv2 and then relicensed to GPLv3 or LGPLv3, in QEMU under GPLv2+. Th= is > relicensing has been acked by all contributors that had contributed to = the > code since the v2->v3 relicense. ACKs approving the v2+ relicensing are= > listed below. The list might include ACKs from people not holding > copyright on any parts of the reused code, but it's better to err on th= e > side of caution and include them. >=20 =2E.. Thanks for tracking that down. >=20 > Changes since v1, based on prototype code from Michael Tsirkin: > - "hw/i386/pc.c" is too big, create new file "hw/i386/acpi.c" with > i386-specific ACPI table stuff, > - separate preparation of individual tables from their installation as > fw_cfg files, > - install these fw_cfg files inside pc_memory_init(), which is shared b= y > piix4/q35, > - add the above licensing-related block to the commit message. This paragraph of information usually appears... >=20 > Signed-off-by: Laszlo Ersek > --- =2E..here, so someone doing 'git am' on the message doesn't include information that is essential to the review process, but worthless to the ultimate git history (readers of 'git log' don't care how many iterations a patch took before it was ready to be included). > hw/i386/acpi.h | 9 +++ > hw/i386/acpi.c | 159 +++++++++++++++++++++++++++++++++++++++++= ++++++++ > hw/i386/pc.c | 16 +++++ > hw/i386/Makefile.objs | 1 + > 4 files changed, 185 insertions(+), 0 deletions(-) > create mode 100644 hw/i386/acpi.h > create mode 100644 hw/i386/acpi.c Sorry - I just did a superficial review of the commit message, but this is in code that I'm not familiar enough with to do any sort of formal review. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2PXQGMTUWTGONWTXSKDCB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRbGzlAAoJEKeha0olJ0NqFi8H/ilN4F30D7rG3lm6duyLL7tg behykf9s82eJzarphr76ChOsCQxGpJ6XA4QYtl0SP1D2+6ALTPWIyLuDOkkELrU9 B4FDyBLgvBFS4hyrRxwB3A4b/NJFJaMouS6eZhFpe3yXI6M7IK1a+042elLG6t81 yOvByekzjsWUNStFfUcDNcaUpbcsvpM+eC6CtcqMKuJoFHLv/Yt3/W/DEUmajsiC Hse7L480YVSXi7olkD9diCxvkKRJ21SdMbm53FkMpwVYasst3y+Xhcx/HFewQQ8l yiLLjRWELEMENG1vr29wiV5UVOpiuAa7tsELEJrDfS3CwJkWw/4Sle/haTN0ikM= =UNIK -----END PGP SIGNATURE----- ------enig2PXQGMTUWTGONWTXSKDCB--