From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57012) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1URvng-0008V7-0Q for qemu-devel@nongnu.org; Mon, 15 Apr 2013 22:39:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1URvnd-0007Pe-PC for qemu-devel@nongnu.org; Mon, 15 Apr 2013 22:39:15 -0400 Received: from e35.co.us.ibm.com ([32.97.110.153]:43136) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1URvnd-0007OL-I6 for qemu-devel@nongnu.org; Mon, 15 Apr 2013 22:39:13 -0400 Received: from /spool/local by e35.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 15 Apr 2013 20:39:08 -0600 Received: from d03relay01.boulder.ibm.com (d03relay01.boulder.ibm.com [9.17.195.226]) by d03dlp03.boulder.ibm.com (Postfix) with ESMTP id C5E8A19D8043 for ; Mon, 15 Apr 2013 20:37:16 -0600 (MDT) Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by d03relay01.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r3G2bLsD122310 for ; Mon, 15 Apr 2013 20:37:21 -0600 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r3G2bK03032059 for ; Mon, 15 Apr 2013 20:37:21 -0600 Message-ID: <516CB960.7080408@linux.vnet.ibm.com> Date: Mon, 15 Apr 2013 21:37:20 -0500 From: Jesse Larrew MIME-Version: 1.0 References: <1365992066-24348-1-git-send-email-lig.fnst@cn.fujitsu.com> In-Reply-To: <1365992066-24348-1-git-send-email-lig.fnst@cn.fujitsu.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 1/3] debugcon: fix always print "addr=0x0, val=0x0" bug List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: liguang Cc: qemu-devel@nongnu.org On 04/14/2013 09:14 PM, liguang wrote: > when use DEBUG_DEBUGCON, screen spits: > debugcon: write addr=0x0000 val=0x00 > Rdebugcon: write addr=0x0000 val=0x00 > udebugcon: write addr=0x0000 val=0x00 > ndebugcon: write addr=0x0000 val=0x00 > ndebugcon: write addr=0x0000 val=0x00 > idebugcon: write addr=0x0000 val=0x00 > ndebugcon: write addr=0x0000 val=0x00 > gdebugcon: write addr=0x0000 val=0x00 > debugcon: write addr=0x0000 val=0x00 > odebugcon: write addr=0x0000 val=0x00 > pdebugcon: write addr=0x0000 val=0x00 > tdebugcon: write addr=0x0000 val=0x00 > idebugcon: write addr=0x0000 val=0x00 > odebugcon: write addr=0x0000 val=0x00 > ndebugcon: write addr=0x0000 val=0x00 > debugcon: write addr=0x0000 val=0x00 > rdebugcon: write addr=0x0000 val=0x00 > odebugcon: write addr=0x0000 val=0x00 > mdebugcon: write addr=0x0000 val=0x00 > debugcon: write addr=0x0000 val=0x00 > adebugcon: write addr=0x0000 val=0x00 > tdebugcon: write addr=0x0000 val=0x00 > debugcon: write addr=0x0000 val=0x00 > > Oh, that's wrong, val is not always be 0. > this bug caused by lack of length modifier > for specifier 'x'. > > Signed-off-by: liguang > --- > hw/char/debugcon.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/hw/char/debugcon.c b/hw/char/debugcon.c > index 0588eeb..44c93e1 100644 > --- a/hw/char/debugcon.c > +++ b/hw/char/debugcon.c > @@ -55,7 +55,7 @@ static void debugcon_ioport_write(void *opaque, hwaddr addr, uint64_t val, > unsigned char ch = val; > > #ifdef DEBUG_DEBUGCON > - printf("debugcon: write addr=0x%04x val=0x%02x\n", addr, val); > + printf("debugcon: write addr=0x%04" HWADDR_PRIx " val=0x%02x\n", addr, val); > #endif > > qemu_chr_fe_write(s->chr, &ch, 1); > Reviewed-by: Jesse Larrew Jesse Larrew Software Engineer, KVM Team IBM Linux Technology Center Phone: (512) 973-2052 (T/L: 363-2052) jlarrew@linux.vnet.ibm.com