From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:57932)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jlarrew@linux.vnet.ibm.com>) id 1URvsP-0001tt-IY
	for qemu-devel@nongnu.org; Mon, 15 Apr 2013 22:44:10 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jlarrew@linux.vnet.ibm.com>) id 1URvsO-0000dy-M9
	for qemu-devel@nongnu.org; Mon, 15 Apr 2013 22:44:09 -0400
Received: from e9.ny.us.ibm.com ([32.97.182.139]:58987)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jlarrew@linux.vnet.ibm.com>) id 1URvsO-0000dr-I3
	for qemu-devel@nongnu.org; Mon, 15 Apr 2013 22:44:08 -0400
Received: from /spool/local
	by e9.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only!
	Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <jlarrew@linux.vnet.ibm.com>;
	Mon, 15 Apr 2013 22:44:08 -0400
Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236])
	by d01dlp02.pok.ibm.com (Postfix) with ESMTP id 5D3786E804C
	for <qemu-devel@nongnu.org>; Mon, 15 Apr 2013 22:44:03 -0400 (EDT)
Received: from d01av05.pok.ibm.com (d01av05.pok.ibm.com [9.56.224.195])
	by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	r3G2i5Y1288208
	for <qemu-devel@nongnu.org>; Mon, 15 Apr 2013 22:44:05 -0400
Received: from d01av05.pok.ibm.com (loopback [127.0.0.1])
	by d01av05.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	r3G2i5Ms028818
	for <qemu-devel@nongnu.org>; Mon, 15 Apr 2013 22:44:05 -0400
Message-ID: <516CBAF4.5010701@linux.vnet.ibm.com>
Date: Mon, 15 Apr 2013 21:44:04 -0500
From: Jesse Larrew <jlarrew@linux.vnet.ibm.com>
MIME-Version: 1.0
References: <1365992066-24348-1-git-send-email-lig.fnst@cn.fujitsu.com>
	<1365992066-24348-2-git-send-email-lig.fnst@cn.fujitsu.com>
In-Reply-To: <1365992066-24348-2-git-send-email-lig.fnst@cn.fujitsu.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 2/3] debugcon: make debug message more
 readable
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: liguang <lig.fnst@cn.fujitsu.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org

On 04/14/2013 09:14 PM, liguang wrote:
>  #ifdef DEBUG_DEBUGCON
> -    printf("debugcon: write addr=0x%04" HWADDR_PRIx " val=0x%02x\n", addr, val);
> +    printf(" [debugcon: write addr=0x%04" HWADDR_PRIx " val=0x%02]\n", addr, val);

I like the reformatting, but it looks like you accidentally clobbered the
'x' when you added the ']'. This is the cause of the compiler warnings in
patch #3.

Jesse Larrew
Software Engineer, KVM Team
IBM Linux Technology Center
Phone: (512) 973-2052 (T/L: 363-2052)
jlarrew@linux.vnet.ibm.com