From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59578) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1URvzf-0002ZT-DI for qemu-devel@nongnu.org; Mon, 15 Apr 2013 22:51:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1URvze-0003Pn-8L for qemu-devel@nongnu.org; Mon, 15 Apr 2013 22:51:39 -0400 Received: from e9.ny.us.ibm.com ([32.97.182.139]:35530) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1URvze-0003Ph-3z for qemu-devel@nongnu.org; Mon, 15 Apr 2013 22:51:38 -0400 Received: from /spool/local by e9.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 15 Apr 2013 22:51:37 -0400 Received: from d01relay07.pok.ibm.com (d01relay07.pok.ibm.com [9.56.227.147]) by d01dlp02.pok.ibm.com (Postfix) with ESMTP id DFE696E803F for ; Mon, 15 Apr 2013 22:51:32 -0400 (EDT) Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by d01relay07.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r3G2pZ2S62193842 for ; Mon, 15 Apr 2013 22:51:35 -0400 Received: from d01av01.pok.ibm.com (loopback [127.0.0.1]) by d01av01.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r3G2pY06008713 for ; Mon, 15 Apr 2013 22:51:34 -0400 Message-ID: <516CBCB6.70806@linux.vnet.ibm.com> Date: Mon, 15 Apr 2013 21:51:34 -0500 From: Jesse Larrew MIME-Version: 1.0 References: <1365992066-24348-1-git-send-email-lig.fnst@cn.fujitsu.com> <1365992066-24348-3-git-send-email-lig.fnst@cn.fujitsu.com> In-Reply-To: <1365992066-24348-3-git-send-email-lig.fnst@cn.fujitsu.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v2 3/3] debugcon: fix compiler warning when open DEBUG_DEBUGCON List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: liguang Cc: Anthony Liguori , qemu-devel@nongnu.org On 04/14/2013 09:14 PM, liguang wrote: > compiler warnings: > CC hw/char/debugcon.o > hw/char/debugcon.c: In function ‘debugcon_ioport_write’: > hw/char/debugcon.c:58: warning: format ‘%02x’ expects type ‘unsigned int’, but argument 3 has type ‘uint64_t’ > hw/char/debugcon.c: In function ‘debugcon_ioport_read’: > hw/char/debugcon.c:70: warning: format ‘%04x’ expects type ‘unsigned int’, but argument 2 has type ‘hwaddr’ > > Signed-off-by: liguang > --- > hw/char/debugcon.c | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/hw/char/debugcon.c b/hw/char/debugcon.c > index b6f2b06..a0d3633 100644 > --- a/hw/char/debugcon.c > +++ b/hw/char/debugcon.c > @@ -33,7 +33,7 @@ > #define ISA_DEBUGCON_DEVICE(obj) \ > OBJECT_CHECK(ISADebugconState, (obj), TYPE_ISA_DEBUGCON_DEVICE) > > -//#define DEBUG_DEBUGCON > +#define DEBUG_DEBUGCON > This is probably useful for testing, but I don't think we want this enabled permanently. > typedef struct DebugconState { > MemoryRegion io; > @@ -55,7 +55,7 @@ static void debugcon_ioport_write(void *opaque, hwaddr addr, uint64_t val, > unsigned char ch = val; > > #ifdef DEBUG_DEBUGCON > - printf(" [debugcon: write addr=0x%04" HWADDR_PRIx " val=0x%02]\n", addr, val); > + printf(" [debugcon: write addr=0x%04" HWADDR_PRIx " val=0x%02" PRIx64 "]\n", addr, val); > #endif > Since this was introduced by patch #2, just squash this hunk together with that one when you resubmit. > qemu_chr_fe_write(s->chr, &ch, 1); > @@ -67,7 +67,7 @@ static uint64_t debugcon_ioport_read(void *opaque, hwaddr addr, unsigned width) > DebugconState *s = opaque; > > #ifdef DEBUG_DEBUGCON > - printf("debugcon: read addr=0x%04x\n", addr); > + printf("debugcon: read addr=0x%04" HWADDR_PRIx "\n", addr); I noticed that you only added brackets to the 'write' messages, but not the 'read' messages. Was that intentional? > #endif > > return s->readback; > Jesse Larrew Software Engineer, KVM Team IBM Linux Technology Center Phone: (512) 973-2052 (T/L: 363-2052) jlarrew@linux.vnet.ibm.com