From: Eric Blake <eblake@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: aik@ozlabs.ru, pbonzini@redhat.com, aliguori@us.ibm.com,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Fix warnings suppressors to honor --disable-werror
Date: Tue, 16 Apr 2013 06:38:20 -0600 [thread overview]
Message-ID: <516D463C.8090307@redhat.com> (raw)
In-Reply-To: <1366113066-1340-1-git-send-email-armbru@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 598 bytes --]
On 04/16/2013 05:51 AM, Markus Armbruster wrote:
> Replace
>
> #pragma GCC diagnostic ignored FOO
> [Troublesome code...]
> #pragma GCC diagnostic error FOO
>
> by
>
> #pragma GCC diagnostic push
> #pragma GCC diagnostic ignored FOO
> [Troublesome code...]
> #pragma GCC diagnostic pop
Older gcc does not understand #pragma GCC diagnostic push. Are you sure
this solution works with all versions of gcc in common use for compiling
qemu?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
next prev parent reply other threads:[~2013-04-16 12:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-16 11:51 [Qemu-devel] [PATCH] Fix warnings suppressors to honor --disable-werror Markus Armbruster
2013-04-16 12:38 ` Eric Blake [this message]
2013-04-16 13:08 ` Markus Armbruster
2013-04-22 18:35 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516D463C.8090307@redhat.com \
--to=eblake@redhat.com \
--cc=aik@ozlabs.ru \
--cc=aliguori@us.ibm.com \
--cc=armbru@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).