From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37573) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1US59U-0001c6-Jj for qemu-devel@nongnu.org; Tue, 16 Apr 2013 08:38:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1US59S-0004yM-42 for qemu-devel@nongnu.org; Tue, 16 Apr 2013 08:38:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:21814) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1US59R-0004y6-ST for qemu-devel@nongnu.org; Tue, 16 Apr 2013 08:38:22 -0400 Message-ID: <516D463C.8090307@redhat.com> Date: Tue, 16 Apr 2013 06:38:20 -0600 From: Eric Blake MIME-Version: 1.0 References: <1366113066-1340-1-git-send-email-armbru@redhat.com> In-Reply-To: <1366113066-1340-1-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2OIVAMLFDUJOFIAHPGIGW" Subject: Re: [Qemu-devel] [PATCH] Fix warnings suppressors to honor --disable-werror List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: aik@ozlabs.ru, pbonzini@redhat.com, aliguori@us.ibm.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2OIVAMLFDUJOFIAHPGIGW Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 04/16/2013 05:51 AM, Markus Armbruster wrote: > Replace >=20 > #pragma GCC diagnostic ignored FOO > [Troublesome code...] > #pragma GCC diagnostic error FOO >=20 > by >=20 > #pragma GCC diagnostic push > #pragma GCC diagnostic ignored FOO > [Troublesome code...] > #pragma GCC diagnostic pop Older gcc does not understand #pragma GCC diagnostic push. Are you sure this solution works with all versions of gcc in common use for compiling qemu? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2OIVAMLFDUJOFIAHPGIGW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRbUY8AAoJEKeha0olJ0NqIRoH/A4YSGlBaaSYxQFnpJSffm0h bz6C0IKZpqJsgO0mvbmWLQwKNxBUXwYaeZGqn2IyclIYknyYUXX6ckwA6UT27ODe 0UKbYEENMK6ZijhZttsGyVSNex1upx1uG9tTCsAIuDUogD0yPvtMukX1QMZVXTWQ V1+VR0kHDV8eCGPRWsolUmSt2VUMLEqRrHSlbR8Y+zEH/pCkN3/HOzZrCt6n851N aJgJLqw1kTaU2tNS3rxFNEzcZnS45J3AYqO8p1gPIZjAsGCvf7L8b9w7AYpR6U86 VVLr/JSUpA1P04z9YLULjvN1vNsGuVx1m94fc478s4+vOxqlqIumGaqKfAoavy4= =uzu3 -----END PGP SIGNATURE----- ------enig2OIVAMLFDUJOFIAHPGIGW--