From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57422) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USFZh-0005L8-FC for qemu-devel@nongnu.org; Tue, 16 Apr 2013 19:46:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1USFZg-0006sQ-9Y for qemu-devel@nongnu.org; Tue, 16 Apr 2013 19:46:09 -0400 Received: from qmta01.emeryville.ca.mail.comcast.net ([2001:558:fe2d:43:76:96:30:16]:57489) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USFZf-0006rb-WA for qemu-devel@nongnu.org; Tue, 16 Apr 2013 19:46:08 -0400 Message-ID: <516DE1E1.4050306@redhat.com> Date: Tue, 16 Apr 2013 17:42:25 -0600 From: Eric Blake MIME-Version: 1.0 References: <1365843407-16504-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1365843407-16504-15-git-send-email-xiawenc@linux.vnet.ibm.com> In-Reply-To: <1365843407-16504-15-git-send-email-xiawenc@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2HCPLPVTABXDCKKRIDKRG" Subject: Re: [Qemu-devel] [PATCH V12 14/18] block: dump to monitor for bdrv_snapshot_dump() and bdrv_image_info_dump() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: kwolf@redhat.com, phrdina@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, stefanha@gmail.com, pbonzini@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2HCPLPVTABXDCKKRIDKRG Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 04/13/2013 02:56 AM, Wenchao Xia wrote: > This patch introduce a new print function, which will output message = to > monitor when it present. With it, bdrv_snapshot_dump() need no more buf= fer > and can avoid string truncation, bdrv_image_info_dump() can also be use= d by > hmp code later, besides qemu-img code. Not a full review (yet), but can we get this particular cleanup rebased to be done first in isolation, since Pavel's patches would benefit from being based on top of this cleanup as well? https://lists.gnu.org/archive/html/qemu-devel/2013-04/msg03287.html --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2HCPLPVTABXDCKKRIDKRG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRbeHhAAoJEKeha0olJ0Nq86kH/RxbARP1Uz1at9yczSHLg4po zREsmQ1g37DQgOZjcYq6tGVYyqNXBCF0s98Hg6EWG5XwtVDnirO9uIui1PcUsABX FoR1P5SAaZjr1jWF0VeG6SsdmILVp18/Lbz+K5tlPDMZetDkwaYiUaHjacuG3vKB uZWODiGN+u2nJLhvFNXMzpzjQAMW3ZIV6sS+Kz3XBFKlfmljQ7V2C2/sZVPoqjCd 348fJYVxfqoQfpuGX3IZmLfx6oR2uLQs0T7INmJV+FLyDk7ETKRztt4z/QwAlnTr 1cQQPwdfZfvPnUh6RPYIloGarQnbF93/zHtHgWoPFsBLedymkHQQL42p4NR+95Y= =2Zif -----END PGP SIGNATURE----- ------enig2HCPLPVTABXDCKKRIDKRG--