From: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
To: Eric Blake <eblake@redhat.com>
Cc: kwolf@redhat.com, phrdina@redhat.com, qemu-devel@nongnu.org,
stefanha@gmail.com, armbru@redhat.com, lcapitulino@redhat.com,
pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH V12 14/18] block: dump to monitor for bdrv_snapshot_dump() and bdrv_image_info_dump()
Date: Wed, 17 Apr 2013 13:25:28 +0800 [thread overview]
Message-ID: <516E3248.9000707@linux.vnet.ibm.com> (raw)
In-Reply-To: <516DE1E1.4050306@redhat.com>
于 2013-4-17 7:42, Eric Blake 写道:
> On 04/13/2013 02:56 AM, Wenchao Xia wrote:
>> This patch introduce a new print function, which will output message to
>> monitor when it present. With it, bdrv_snapshot_dump() need no more buffer
>> and can avoid string truncation, bdrv_image_info_dump() can also be used by
>> hmp code later, besides qemu-img code.
>
> Not a full review (yet), but can we get this particular cleanup rebased
> to be done first in isolation, since Pavel's patches would benefit from
> being based on top of this cleanup as well?
>
> https://lists.gnu.org/archive/html/qemu-devel/2013-04/msg03287.html
>
I hope this serial have no more issues to be commited, avoiding
troubles in rebasing and file moves.
--
Best Regards
Wenchao Xia
next prev parent reply other threads:[~2013-04-17 5:25 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-13 8:56 [Qemu-devel] [PATCH V12 00/18] qmp/hmp interfaces for internal snapshot info Wenchao Xia
2013-04-13 8:56 ` [Qemu-devel] [PATCH V12 01/18] block: move bdrv_snapshot_find() to block/snapshot.c Wenchao Xia
2013-04-13 8:56 ` [Qemu-devel] [PATCH V12 02/18] block: distinguish id and name in bdrv_find_snapshot() Wenchao Xia
2013-04-17 1:09 ` Eric Blake
2013-04-17 18:50 ` Eric Blake
2013-04-13 8:56 ` [Qemu-devel] [PATCH V12 03/18] qemu-img: remove unused parameter in collect_image_info() Wenchao Xia
2013-04-13 8:56 ` [Qemu-devel] [PATCH V12 04/18] block: move collect_snapshots() and collect_image_info() to block/qapi.c Wenchao Xia
2013-04-13 8:56 ` [Qemu-devel] [PATCH V12 05/18] block: add snapshot info query function bdrv_query_snapshot_info_list() Wenchao Xia
2013-04-13 8:56 ` [Qemu-devel] [PATCH V12 06/18] block: add check for VM snapshot in bdrv_query_snapshot_info_list() Wenchao Xia
2013-04-17 20:52 ` Eric Blake
2013-04-18 4:07 ` Wenchao Xia
2013-04-13 8:56 ` [Qemu-devel] [PATCH V12 07/18] block: change VM snapshot checking logic Wenchao Xia
2013-04-17 21:58 ` Eric Blake
2013-04-13 8:56 ` [Qemu-devel] [PATCH V12 08/18] block: add image info query function bdrv_query_image_info() Wenchao Xia
2013-04-17 22:56 ` Eric Blake
2013-04-13 8:56 ` [Qemu-devel] [PATCH V12 09/18] block: move qmp_query_block() and bdrv_query_info() to block/qapi.c Wenchao Xia
2013-04-13 8:56 ` [Qemu-devel] [PATCH V12 10/18] qmp: add interface query-snapshots Wenchao Xia
2013-04-17 23:03 ` Eric Blake
2013-04-13 8:56 ` [Qemu-devel] [PATCH V12 11/18] qmp: add recursive member in ImageInfo Wenchao Xia
2013-04-13 8:56 ` [Qemu-devel] [PATCH V12 12/18] qmp: add ImageInfo in BlockDeviceInfo used by query-block Wenchao Xia
2013-04-13 8:56 ` [Qemu-devel] [PATCH V12 13/18] block: move bdrv_snapshot_dump() and dump_human_image_info() to block/qapi.c Wenchao Xia
2013-04-13 8:56 ` [Qemu-devel] [PATCH V12 14/18] block: dump to monitor for bdrv_snapshot_dump() and bdrv_image_info_dump() Wenchao Xia
2013-04-16 23:42 ` Eric Blake
2013-04-17 5:25 ` Wenchao Xia [this message]
2013-04-13 8:56 ` [Qemu-devel] [PATCH V12 15/18] hmp: add function hmp_info_snapshots() Wenchao Xia
2013-04-13 8:56 ` [Qemu-devel] [PATCH V12 16/18] hmp: switch snapshot info function to qmp based one Wenchao Xia
2013-04-13 8:56 ` [Qemu-devel] [PATCH V12 17/18] hmp: show ImageInfo in 'info block' Wenchao Xia
2013-04-13 8:56 ` [Qemu-devel] [PATCH V12 18/18] hmp: add parameters device and -v for info block Wenchao Xia
2013-04-22 2:58 ` [Qemu-devel] [PATCH V12 00/18] qmp/hmp interfaces for internal snapshot info Wenchao Xia
2013-04-22 8:27 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516E3248.9000707@linux.vnet.ibm.com \
--to=xiawenc@linux.vnet.ibm.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=pbonzini@redhat.com \
--cc=phrdina@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).