From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56677) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USKsU-0002ey-30 for qemu-devel@nongnu.org; Wed, 17 Apr 2013 01:25:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1USKsT-0006SM-4r for qemu-devel@nongnu.org; Wed, 17 Apr 2013 01:25:54 -0400 Received: from e28smtp02.in.ibm.com ([122.248.162.2]:59684) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USKsS-0006Rr-Io for qemu-devel@nongnu.org; Wed, 17 Apr 2013 01:25:53 -0400 Received: from /spool/local by e28smtp02.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 17 Apr 2013 10:50:30 +0530 Received: from d28relay01.in.ibm.com (d28relay01.in.ibm.com [9.184.220.58]) by d28dlp03.in.ibm.com (Postfix) with ESMTP id 5079D125804F for ; Wed, 17 Apr 2013 10:57:16 +0530 (IST) Received: from d28av02.in.ibm.com (d28av02.in.ibm.com [9.184.220.64]) by d28relay01.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r3H5PdvY61210626 for ; Wed, 17 Apr 2013 10:55:39 +0530 Received: from d28av02.in.ibm.com (loopback [127.0.0.1]) by d28av02.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r3H5PiQU010243 for ; Wed, 17 Apr 2013 15:25:44 +1000 Message-ID: <516E3248.9000707@linux.vnet.ibm.com> Date: Wed, 17 Apr 2013 13:25:28 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1365843407-16504-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1365843407-16504-15-git-send-email-xiawenc@linux.vnet.ibm.com> <516DE1E1.4050306@redhat.com> In-Reply-To: <516DE1E1.4050306@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH V12 14/18] block: dump to monitor for bdrv_snapshot_dump() and bdrv_image_info_dump() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: kwolf@redhat.com, phrdina@redhat.com, qemu-devel@nongnu.org, stefanha@gmail.com, armbru@redhat.com, lcapitulino@redhat.com, pbonzini@redhat.com 于 2013-4-17 7:42, Eric Blake 写道: > On 04/13/2013 02:56 AM, Wenchao Xia wrote: >> This patch introduce a new print function, which will output message to >> monitor when it present. With it, bdrv_snapshot_dump() need no more buffer >> and can avoid string truncation, bdrv_image_info_dump() can also be used by >> hmp code later, besides qemu-img code. > > Not a full review (yet), but can we get this particular cleanup rebased > to be done first in isolation, since Pavel's patches would benefit from > being based on top of this cleanup as well? > > https://lists.gnu.org/archive/html/qemu-devel/2013-04/msg03287.html > I hope this serial have no more issues to be commited, avoiding troubles in rebasing and file moves. -- Best Regards Wenchao Xia