From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:53740)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1USSIa-0000Sb-Fb
	for qemu-devel@nongnu.org; Wed, 17 Apr 2013 09:21:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1USSIY-00067v-Ct
	for qemu-devel@nongnu.org; Wed, 17 Apr 2013 09:21:20 -0400
Received: from mx1.redhat.com ([209.132.183.28]:50893)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1USSIY-00067U-5Z
	for qemu-devel@nongnu.org; Wed, 17 Apr 2013 09:21:18 -0400
Message-ID: <516EA182.80005@redhat.com>
Date: Wed, 17 Apr 2013 15:20:02 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1366204073-8468-1-git-send-email-stefanha@redhat.com>
	<1366204073-8468-6-git-send-email-stefanha@redhat.com>
In-Reply-To: <1366204073-8468-6-git-send-email-stefanha@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 05/17] aio: stop using .io_flush()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Anthony Liguori <aliguori@us.ibm.com>, pingfank@linux.vnet.ibm.com, qemu-devel@nongnu.org

Il 17/04/2013 15:07, Stefan Hajnoczi ha scritto:
> 
> Due to this change we need to update tests/test-aio.c which asserts
> aio_poll() return values.  Note that QEMU doesn't actually rely on these
> return values so only tests/test-aio.c cares.
> 
> Note that ctx->notifier, the EventNotifier fd used for aio_notify(), is
> now handled as a special case.  This is a little ugly but maintains
> aio_poll() semantics, i.e. aio_notify() does not count as 'progress' and
> aio_poll() avoids blocking when the user has not set any fd handlers yet.
> 
> Patches after this remove .io_flush() handler code until we can finally
> drop the io_flush arguments to aio_set_fd_handler() and friends.

Dropping aio_poll()'s return value is ok (as a follow up).  The test
generally test for progress anyway with assertions on the results of the
notify callbacks.

Paolo