From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:46276)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1USTK9-0005gM-BF
	for qemu-devel@nongnu.org; Wed, 17 Apr 2013 10:27:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1USTJw-0005G2-KX
	for qemu-devel@nongnu.org; Wed, 17 Apr 2013 10:27:01 -0400
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <516EB124.2010701@twiddle.net>
Date: Wed, 17 Apr 2013 16:26:44 +0200
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1365857251-28173-1-git-send-email-aurelien@aurel32.net>
	<1365857251-28173-10-git-send-email-aurelien@aurel32.net>
In-Reply-To: <1365857251-28173-10-git-send-email-aurelien@aurel32.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 09/10] target-ppc: emulate store doubleword
 pair instructions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>

On 2013-04-13 14:47, Aurelien Jarno wrote:
> +        gen_qemu_st64(ctx, cpu_fpr[rD(ctx->opcode) + 1], EA);

Actually, for both this and ldfp, don't you need to check for
odd rD and raise sigill or whatever?


r~