From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49795) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USUnE-0001RM-37 for qemu-devel@nongnu.org; Wed, 17 Apr 2013 12:01:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1USUn8-0006tN-FN for qemu-devel@nongnu.org; Wed, 17 Apr 2013 12:01:07 -0400 Received: from e8.ny.us.ibm.com ([32.97.182.138]:60172) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USUn8-0006tH-Ax for qemu-devel@nongnu.org; Wed, 17 Apr 2013 12:01:02 -0400 Received: from /spool/local by e8.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 17 Apr 2013 12:01:01 -0400 Received: from d01relay01.pok.ibm.com (d01relay01.pok.ibm.com [9.56.227.233]) by d01dlp02.pok.ibm.com (Postfix) with ESMTP id AA0B66E805C for ; Wed, 17 Apr 2013 12:00:55 -0400 (EDT) Received: from d01av03.pok.ibm.com (d01av03.pok.ibm.com [9.56.224.217]) by d01relay01.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r3HG0vEk280768 for ; Wed, 17 Apr 2013 12:00:58 -0400 Received: from d01av03.pok.ibm.com (loopback [127.0.0.1]) by d01av03.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r3HG0viK006344 for ; Wed, 17 Apr 2013 13:00:57 -0300 Message-ID: <516EC738.6050909@linux.vnet.ibm.com> Date: Wed, 17 Apr 2013 12:00:56 -0400 From: "Michael R. Hines" MIME-Version: 1.0 References: <1366172418-8729-1-git-send-email-mrhines@linux.vnet.ibm.com> <1366172418-8729-4-git-send-email-mrhines@linux.vnet.ibm.com> <516EC351.3090205@redhat.com> In-Reply-To: <516EC351.3090205@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL v3 3/7] rdma: introduce capability for chunk registration List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: aliguori@us.ibm.com, quintela@redhat.com, mst@redhat.com, qemu-devel@nongnu.org, owasserm@redhat.com, abali@us.ibm.com, mrhines@us.ibm.com, gokul@us.ibm.com, pbonzini@redhat.com On 04/17/2013 11:44 AM, Eric Blake wrote: > On 04/16/2013 10:20 PM, mrhines@linux.vnet.ibm.com wrote: >> From: "Michael R. Hines" >> >> This capability allows you to disable dynamic chunk registration >> for better throughput on high-performance links. >> >> It is enabled by default. >> >> Signed-off-by: Michael R. Hines >> --- >> +++ b/qapi-schema.json >> @@ -602,7 +602,7 @@ >> # Since: 1.2 > Normally, I'd ask that you document the option above; something like: > > # @x-chunk-register-destination: do something (since 1.5) > >> ## >> { 'enum': 'MigrationCapability', >> - 'data': ['xbzrle'] } >> + 'data': ['xbzrle', 'x-chunk-register-destination'] } > But given the x- prefix, which is already a designation that the option > is experimental and may be pulled, I can live without documentation here > (where JUST the RDMA documentation, which mentions this capability, is > sufficient). Therefore: > > Reviewed-by: Eric Blake > My apologies - I'm more than happy to add documentation. Will include in next patch.