From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37164) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USWko-0003eB-2W for qemu-devel@nongnu.org; Wed, 17 Apr 2013 14:06:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1USWkh-0004zR-5U for qemu-devel@nongnu.org; Wed, 17 Apr 2013 14:06:46 -0400 Received: from cantor2.suse.de ([195.135.220.15]:41662 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USWkg-0004z1-Sa for qemu-devel@nongnu.org; Wed, 17 Apr 2013 14:06:39 -0400 Message-ID: <516EE4AD.3090508@suse.de> Date: Wed, 17 Apr 2013 20:06:37 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1364971345-3110-1-git-send-email-jfrei@linux.vnet.ibm.com> In-Reply-To: <1364971345-3110-1-git-send-email-jfrei@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [RFC/PATCH 0/1] cpu hotplug for s390 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jens Freimann Cc: Eduardo Habkost , qemu-devel , Alexander Graf , Christian Borntraeger , Cornelia Huck , Igor Mammedov Hi Jens, Am 03.04.2013 08:42, schrieb Jens Freimann: > this is what our approach to CPU hotplug looks like. > With respect to Igor's CPU hotplug series, how should we proceed?=20 > Should we change the interface to=20 > qemu_system_cpu_add_notifier/qemu_system_cpu_hotplug_request/cpu-add et= c? I am wondering if my recent qdev/device_add fixes would allow to implement CPU hot-add via device_add for s390x? Background is that for x86 we currently have a flat CPU core/thread namespace but would need to deal with sockets, cores and threads to get topologies right. I assume there are no such issues on s390x, so that the vCPU to CPUState mapping could stay 1:1? > Feedback regarding the non-API part is also highly welcome! I did spot some QOM'ish nitpicks in the qdev_create() but I am wondering if you and Alex see an urgent need to get this into 1.5 during the Soft Freeze or whether we can just align it to x86 work for now and deal with it after the release? Regards, Andreas > Thang Pham (1): > s390: implement CPU hotplug >=20 > hmp-commands.hx | 14 +++++ > hw/s390x/Makefile.objs | 2 +- > hw/s390x/event-facility.c | 9 ++++ > hw/s390x/event-facility.h | 3 ++ > hw/s390x/s390-virtio.c | 34 +++++++++--- > hw/s390x/sclp.c | 134 ++++++++++++++++++++++++++++++++++++++= +++++++- > hw/s390x/sclp.h | 47 +++++++++++++++- > include/sysemu/sysemu.h | 1 + > monitor.c | 31 +++++++++++ > target-s390x/cpu.c | 59 ++++++++++++++++++++ > target-s390x/cpu.h | 7 +++ > target-s390x/helper.c | 43 +++++++++++++++ > vl.c | 6 +++ > 13 files changed, 379 insertions(+), 11 deletions(-) >=20 --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg