Re: [Qemu-devel] [PATCH V12 10/18] qmp: add interface query-snapshots

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1305 bytes --]

On 04/13/2013 02:56 AM, Wenchao Xia wrote:
>   This interface returns info of valid internal snapshots for whole vm.
> 
> Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
> ---
>  block/qapi.c     |   17 +++++++++++++++
>  qapi-schema.json |   14 +++++++++++++
>  qmp-commands.hx  |   58 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 89 insertions(+), 0 deletions(-)

> +query-snapshots
> +---------------
> +
> +Show the internal consistent snapshot information
> +
> +Consistent snapshots are snapshots that exist in all writeable block devices.
> +When 'savevm' takes a snapshot it uses the same ID across all writeable block
> +devices. If a snapshot ID only exists in one block device then it is not a
> +consistent one. Each snapshot is represented by a json-object and the returned
> +value is a json-array of all snapshots

Does it really share the same snapshot ID across all block devices, or
is it just the snapshot tag that gets shared?  That is, if I have just
disk a, take one snapshot, then hotplug disk b, then take another
snapshot, doesn't that leave me with:

disk a: id 1 tag A, id 2 tag B
disk b: id 1 tag B?

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]