From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54253) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USbO4-0004IO-Hw for qemu-devel@nongnu.org; Wed, 17 Apr 2013 19:03:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1USbO3-0003X6-It for qemu-devel@nongnu.org; Wed, 17 Apr 2013 19:03:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:7498) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USbO3-0003Wv-Ai for qemu-devel@nongnu.org; Wed, 17 Apr 2013 19:03:35 -0400 Message-ID: <516F2A42.9060004@redhat.com> Date: Wed, 17 Apr 2013 17:03:30 -0600 From: Eric Blake MIME-Version: 1.0 References: <1365843407-16504-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1365843407-16504-11-git-send-email-xiawenc@linux.vnet.ibm.com> In-Reply-To: <1365843407-16504-11-git-send-email-xiawenc@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2FTWJVFHGGDFAIOPUXWSP" Subject: Re: [Qemu-devel] [PATCH V12 10/18] qmp: add interface query-snapshots List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: kwolf@redhat.com, phrdina@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, stefanha@gmail.com, pbonzini@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2FTWJVFHGGDFAIOPUXWSP Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 04/13/2013 02:56 AM, Wenchao Xia wrote: > This interface returns info of valid internal snapshots for whole vm.= >=20 > Signed-off-by: Wenchao Xia > --- > block/qapi.c | 17 +++++++++++++++ > qapi-schema.json | 14 +++++++++++++ > qmp-commands.hx | 58 ++++++++++++++++++++++++++++++++++++++++++++++= ++++++++ > 3 files changed, 89 insertions(+), 0 deletions(-) > +query-snapshots > +--------------- > + > +Show the internal consistent snapshot information > + > +Consistent snapshots are snapshots that exist in all writeable block d= evices. > +When 'savevm' takes a snapshot it uses the same ID across all writeabl= e block > +devices. If a snapshot ID only exists in one block device then it is n= ot a > +consistent one. Each snapshot is represented by a json-object and the = returned > +value is a json-array of all snapshots Does it really share the same snapshot ID across all block devices, or is it just the snapshot tag that gets shared? That is, if I have just disk a, take one snapshot, then hotplug disk b, then take another snapshot, doesn't that leave me with: disk a: id 1 tag A, id 2 tag B disk b: id 1 tag B? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2FTWJVFHGGDFAIOPUXWSP Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRbypCAAoJEKeha0olJ0NqzAMH/0oVl0WcA15+thKSKmCyaJ3C mn8h4yyXWioPlC1FQi7YFlBKUi9HddC0/wY/XJLh7Wwh/gqMSA+AzP80mj9tcBo2 Pj6CTyPZIF5ZbyTCHfmHDKjqNUIefB4kqrKcLs3MYZ8UPHeir57xNci1OuFLozvR sXEXR865cJ7TQFs+C7Jx/TmJn0POQy7S/zS4y3epaTmmIEHJFY622Klsz80rVNSf PGyyUiKy9v426gkhPsXYRX1EA2qaGl+xUud3bBVnDe6iX0yVRenyYMYzCB6qQaGz pW1JatnGnzZ0d/uDHaIVUVxcaIbEZC3Lp8dU85U03tKyc286w6phZpNgXKl+HaI= =dH8g -----END PGP SIGNATURE----- ------enig2FTWJVFHGGDFAIOPUXWSP--