* [Qemu-devel] [PATCH] console: unbreak cocoa
@ 2013-04-18 6:20 Gerd Hoffmann
2013-04-18 6:33 ` Peter Maydell
0 siblings, 1 reply; 3+ messages in thread
From: Gerd Hoffmann @ 2013-04-18 6:20 UTC (permalink / raw)
To: qemu-devel
Cc: peter.maydell, Andreas Färber, Gerd Hoffmann,
Anthony Liguori
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
ui/cocoa.m | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ui/cocoa.m b/ui/cocoa.m
index 048cc97..14b784d 100644
--- a/ui/cocoa.m
+++ b/ui/cocoa.m
@@ -495,7 +495,7 @@ QemuCocoaView *cocoaView;
if (keycode == 58 || keycode == 69) { // emulate caps lock and num lock keydown and keyup
kbd_put_keycode(keycode);
kbd_put_keycode(keycode | 0x80);
- } else if (is_graphic_console()) {
+ } else if (qemu_console_is_graphic(NULL)) {
if (keycode & 0x80)
kbd_put_keycode(0xe0);
if (modifiers_state[keycode] == 0) { // keydown
@@ -1006,7 +1006,7 @@ static void cocoa_refresh(DisplayChangeListener *dcl)
[cocoaView handleEvent:event];
}
} while(event != nil);
- vga_hw_update();
+ graphic_hw_update(NULL);
}
static void cocoa_cleanup(void)
--
1.7.9.7
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] console: unbreak cocoa
2013-04-18 6:20 [Qemu-devel] [PATCH] console: unbreak cocoa Gerd Hoffmann
@ 2013-04-18 6:33 ` Peter Maydell
2013-04-18 6:47 ` Gerd Hoffmann
0 siblings, 1 reply; 3+ messages in thread
From: Peter Maydell @ 2013-04-18 6:33 UTC (permalink / raw)
To: Gerd Hoffmann; +Cc: Andreas Färber, qemu-devel, Anthony Liguori
On 18 April 2013 07:20, Gerd Hoffmann <kraxel@redhat.com> wrote:
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> ui/cocoa.m | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/ui/cocoa.m b/ui/cocoa.m
> index 048cc97..14b784d 100644
> --- a/ui/cocoa.m
> +++ b/ui/cocoa.m
> @@ -495,7 +495,7 @@ QemuCocoaView *cocoaView;
> if (keycode == 58 || keycode == 69) { // emulate caps lock and num lock keydown and keyup
> kbd_put_keycode(keycode);
> kbd_put_keycode(keycode | 0x80);
> - } else if (is_graphic_console()) {
> + } else if (qemu_console_is_graphic(NULL)) {
This isn't the only use of is_graphic_console(); compare
the patch I sent last night:
http://patchwork.ozlabs.org/patch/237347/
thanks
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] console: unbreak cocoa
2013-04-18 6:33 ` Peter Maydell
@ 2013-04-18 6:47 ` Gerd Hoffmann
0 siblings, 0 replies; 3+ messages in thread
From: Gerd Hoffmann @ 2013-04-18 6:47 UTC (permalink / raw)
To: Peter Maydell; +Cc: Andreas Färber, qemu-devel, Anthony Liguori
Hi,
>> - } else if (is_graphic_console()) {
>> + } else if (qemu_console_is_graphic(NULL)) {
>
> This isn't the only use of is_graphic_console(); compare
> the patch I sent last night:
>
> http://patchwork.ozlabs.org/patch/237347/
Yea, just found it in my inbox.
thanks,
Gerd
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-04-18 6:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-18 6:20 [Qemu-devel] [PATCH] console: unbreak cocoa Gerd Hoffmann
2013-04-18 6:33 ` Peter Maydell
2013-04-18 6:47 ` Gerd Hoffmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).