From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54163) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USjAg-0008Jr-SG for qemu-devel@nongnu.org; Thu, 18 Apr 2013 03:22:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1USjAe-0006aG-NB for qemu-devel@nongnu.org; Thu, 18 Apr 2013 03:22:18 -0400 Received: from e23smtp02.au.ibm.com ([202.81.31.144]:43428) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USjAd-0006Z8-N1 for qemu-devel@nongnu.org; Thu, 18 Apr 2013 03:22:16 -0400 Received: from /spool/local by e23smtp02.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 18 Apr 2013 17:14:27 +1000 Received: from d23relay04.au.ibm.com (d23relay04.au.ibm.com [9.190.234.120]) by d23dlp01.au.ibm.com (Postfix) with ESMTP id 4FD5E2CE8055 for ; Thu, 18 Apr 2013 17:22:06 +1000 (EST) Received: from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97]) by d23relay04.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r3I78c8b2883964 for ; Thu, 18 Apr 2013 17:08:38 +1000 Received: from d23av03.au.ibm.com (loopback [127.0.0.1]) by d23av03.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r3I7M4GS003978 for ; Thu, 18 Apr 2013 17:22:04 +1000 Message-ID: <516F9ECF.8040800@linux.vnet.ibm.com> Date: Thu, 18 Apr 2013 15:20:47 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <13b9d1e79947b89982ec51c421b9b1bd0a7b587d.1366127809.git.phrdina@redhat.com> <516E0E9A.9050607@linux.vnet.ibm.com> <516E54AF.8070206@redhat.com> <516E774D.8080809@linux.vnet.ibm.com> <516E7EB1.8060806@redhat.com> <516EE688.1030704@redhat.com> <516F773E.80108@linux.vnet.ibm.com> In-Reply-To: <516F773E.80108@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 11/11] savevm: remove backward compatibility from bdrv_snapshot_find() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: lcapitulino@redhat.com, Pavel Hrdina , qemu-devel@nongnu.org, armbru@redhat.com >> So, was I convincing enough in arguing that we want something different >> from the approach of both existing patch series? >> > Plenty of details, thanks, Eric. I think Pavel's logic is better, > which increase the capability of it, and I don't think a more complex > logic should be there, since it is an internal function need clear > meaning. > > >>> >> > I understand it helps, but now I need just a good > bdrv_snapshot_find() to use, so could this improvement work > be postponded later? I think neither my or Pavel's work > is depending on it. > Pavel, to make us progress, I'd like a small serial change > bdrv_snapshot_find() first, then we can rebase on it, are u OK > with it? > > block/qapi.c: > int bdrv_snapshot_find(BlockDriverState *bs, QEMUSnapshotInfo *sn_info, > const char *name, const char *id) > > > Actually my serial, two condition are "or" relationship, but in Pavel's they are "and" relationship. From caller, I think "and" is better, and taking two parameter in one function make caller easier to use, in most case. I'd like a clean serial go for it, hope to know Pavel and Markus's idea. -- Best Regards Wenchao Xia