* [Qemu-devel] hw/usb/host-libusb.c:1254:217: error: ‘LIBUSB_LOG_LEVEL_WARNING’ undeclared here (not in a function)
@ 2013-04-18 9:40 Michael Tokarev
2013-04-18 9:54 ` Peter Maydell
2013-04-18 9:56 ` Gerd Hoffmann
0 siblings, 2 replies; 3+ messages in thread
From: Michael Tokarev @ 2013-04-18 9:40 UTC (permalink / raw)
To: Gerd Hoffmann; +Cc: qemu-devel
The error in $subject is spewed when trying to compile current
qemu code on my debian wheezy system.
/usr/include/libusb-1.0/libusb.h does not define any LIBUSB_LOG_LEVEL*
constants. libusb-1.0-0 on my system is of version 1.0.11.
Should we define some minimum libusb-1.0 version requiriment, or
conditionally compile the 'loglevel' property? Which minimum
version is needed?
Thanks,
/mjt
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] hw/usb/host-libusb.c:1254:217: error: ‘LIBUSB_LOG_LEVEL_WARNING’ undeclared here (not in a function)
2013-04-18 9:40 [Qemu-devel] hw/usb/host-libusb.c:1254:217: error: ‘LIBUSB_LOG_LEVEL_WARNING’ undeclared here (not in a function) Michael Tokarev
@ 2013-04-18 9:54 ` Peter Maydell
2013-04-18 9:56 ` Gerd Hoffmann
1 sibling, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2013-04-18 9:54 UTC (permalink / raw)
To: Michael Tokarev; +Cc: Gerd Hoffmann, qemu-devel
On 18 April 2013 10:40, Michael Tokarev <mjt@tls.msk.ru> wrote:
> The error in $subject is spewed when trying to compile current
> qemu code on my debian wheezy system.
>
> /usr/include/libusb-1.0/libusb.h does not define any LIBUSB_LOG_LEVEL*
> constants. libusb-1.0-0 on my system is of version 1.0.11.
>
> Should we define some minimum libusb-1.0 version requiriment, or
> conditionally compile the 'loglevel' property? Which minimum
> version is needed?
I think it would be sufficient for QEMU to use a hardcoded '2'
rather than the symbolic constant -- AFAICT older libusb
provides the functions for setting log level and the same set
of options, it just doesn't provide an enum for them.
(In particular we already rely on the integer values having
well defined and stable meanings across different libusb
versions, because we're exposing access to them to the user
via a pure integer property...)
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] hw/usb/host-libusb.c:1254:217: error: ‘LIBUSB_LOG_LEVEL_WARNING’ undeclared here (not in a function)
2013-04-18 9:40 [Qemu-devel] hw/usb/host-libusb.c:1254:217: error: ‘LIBUSB_LOG_LEVEL_WARNING’ undeclared here (not in a function) Michael Tokarev
2013-04-18 9:54 ` Peter Maydell
@ 2013-04-18 9:56 ` Gerd Hoffmann
1 sibling, 0 replies; 3+ messages in thread
From: Gerd Hoffmann @ 2013-04-18 9:56 UTC (permalink / raw)
To: Michael Tokarev; +Cc: Hans de Goede, qemu-devel
On 04/18/13 11:40, Michael Tokarev wrote:
> The error in $subject is spewed when trying to compile current
> qemu code on my debian wheezy system.
>
> /usr/include/libusb-1.0/libusb.h does not define any LIBUSB_LOG_LEVEL*
> constants. libusb-1.0-0 on my system is of version 1.0.11.
>
> Should we define some minimum libusb-1.0 version requiriment, or
> conditionally compile the 'loglevel' property? Which minimum
> version is needed?
I think we should go for a minimum version requirement.
Dunno which version the loglevels where added, Hans?
cheers,
Gerd
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-04-18 9:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-18 9:40 [Qemu-devel] hw/usb/host-libusb.c:1254:217: error: ‘LIBUSB_LOG_LEVEL_WARNING’ undeclared here (not in a function) Michael Tokarev
2013-04-18 9:54 ` Peter Maydell
2013-04-18 9:56 ` Gerd Hoffmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).