From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33387) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USmJa-0004xG-EP for qemu-devel@nongnu.org; Thu, 18 Apr 2013 06:43:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1USmJZ-0001iw-0U for qemu-devel@nongnu.org; Thu, 18 Apr 2013 06:43:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39775) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USmJY-0001ir-Ox for qemu-devel@nongnu.org; Thu, 18 Apr 2013 06:43:40 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r3IAhdsE021668 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 18 Apr 2013 06:43:39 -0400 Message-ID: <516FCE5A.20103@redhat.com> Date: Thu, 18 Apr 2013 12:43:38 +0200 From: Pavel Hrdina MIME-Version: 1.0 References: <1366277029-17311-1-git-send-email-kwolf@redhat.com> In-Reply-To: <1366277029-17311-1-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] savevm: Improve error message for unmigratable devices List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org On 18.4.2013 11:23, Kevin Wolf wrote: > Trying to take an internal snapshot when an unmigratable device is in > use resuled in an 'Error -22 while writing VM' message. This patch > changes it to print the same error message as migration would print: > 'State blocked by non-migratable device xyz' > > Signed-off-by: Kevin Wolf > --- Hi Kevin, this patch is not needed because I'm fixing the same in my patch series http://lists.nongnu.org/archive/html/qemu-devel/2013-04/msg03287.html in this patch http://lists.nongnu.org/archive/html/qemu-devel/2013-04/msg03298.html . Pavel