From: Paolo Bonzini <pbonzini@redhat.com>
To: Dmitry Fleytman <dmitry@daynix.com>
Cc: Yan Vugenfirer <yan@daynix.com>,
qemu-devel <qemu-devel@nongnu.org>,
Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: [Qemu-devel] [PATCH 1/1 V6] VMWare PVSCSI paravirtual device implementation
Date: Thu, 18 Apr 2013 12:54:37 +0200 [thread overview]
Message-ID: <516FD0ED.1020907@redhat.com> (raw)
In-Reply-To: <CAGHCxhfgMA6gaut3T+CKHH=hw-=WmRo5L1nE8H-ExFHrUaCmVw@mail.gmail.com>
Il 18/04/2013 11:38, Dmitry Fleytman ha scritto:
>
> > +static void
> > +pvscsi_free_queue(PVSCSIRequestList *req_list)
>
> This shouldn't be needed.
>
>
>
> Doesn't one need to clear completion queue on reset command arrival from
> driver?
>
It should happen in qbus_reset_all. The scsi-disk device will cancel
pending requests, and these will be moved from the pending_queue to the
completion_queue. I think you can call pvscsi_process_completion_queue
instead of pvscsi_free_queue.
Paolo
>
> > +{
> > + PVSCSIRequest *pvscsi_req;
> > +
> > + while (!QTAILQ_EMPTY(req_list)) {
> > + pvscsi_req = QTAILQ_FIRST(req_list);
> > + QTAILQ_REMOVE(req_list, pvscsi_req, next);
> > + g_free(pvscsi_req);
> > + }
> > +}
> > +
next prev parent reply other threads:[~2013-04-18 10:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-08 18:39 [Qemu-devel] [PATCH 0/1 V6] VMWare PVSCSI paravirtual device implementation Dmitry Fleytman
2013-04-08 18:39 ` [Qemu-devel] [PATCH 1/1 " Dmitry Fleytman
2013-04-10 9:33 ` Paolo Bonzini
2013-04-18 9:38 ` Dmitry Fleytman
2013-04-18 10:54 ` Paolo Bonzini [this message]
2013-04-18 12:11 ` Dmitry Fleytman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516FD0ED.1020907@redhat.com \
--to=pbonzini@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=dmitry@daynix.com \
--cc=qemu-devel@nongnu.org \
--cc=yan@daynix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).