From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:36146)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1USmUO-0000EE-S3
	for qemu-devel@nongnu.org; Thu, 18 Apr 2013 06:54:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1USmUN-0005Xw-UJ
	for qemu-devel@nongnu.org; Thu, 18 Apr 2013 06:54:52 -0400
Received: from mx1.redhat.com ([209.132.183.28]:6965)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1USmUN-0005Xm-Mq
	for qemu-devel@nongnu.org; Thu, 18 Apr 2013 06:54:51 -0400
Message-ID: <516FD0ED.1020907@redhat.com>
Date: Thu, 18 Apr 2013 12:54:37 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1365446383-11909-1-git-send-email-dmitry@daynix.com>
	<1365446383-11909-2-git-send-email-dmitry@daynix.com>
	<51653204.6050909@redhat.com>
	<CAGHCxhfgMA6gaut3T+CKHH=hw-=WmRo5L1nE8H-ExFHrUaCmVw@mail.gmail.com>
In-Reply-To: <CAGHCxhfgMA6gaut3T+CKHH=hw-=WmRo5L1nE8H-ExFHrUaCmVw@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/1 V6] VMWare PVSCSI paravirtual device
	implementation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Dmitry Fleytman <dmitry@daynix.com>
Cc: Yan Vugenfirer <yan@daynix.com>, qemu-devel <qemu-devel@nongnu.org>, Anthony Liguori <anthony@codemonkey.ws>

Il 18/04/2013 11:38, Dmitry Fleytman ha scritto:
> 
>     > +static void
>     > +pvscsi_free_queue(PVSCSIRequestList *req_list)
> 
>     This shouldn't be needed.
> 
> 
> 
> Doesn't one need to clear completion queue on reset command arrival from
> driver?
> 

It should happen in qbus_reset_all.  The scsi-disk device will cancel
pending requests, and these will be moved from the pending_queue to the
completion_queue.  I think you can call pvscsi_process_completion_queue
instead of pvscsi_free_queue.

Paolo

> 
>     > +{
>     > +    PVSCSIRequest *pvscsi_req;
>     > +
>     > +    while (!QTAILQ_EMPTY(req_list)) {
>     > +        pvscsi_req = QTAILQ_FIRST(req_list);
>     > +        QTAILQ_REMOVE(req_list, pvscsi_req, next);
>     > +        g_free(pvscsi_req);
>     > +    }
>     > +}
>     > +