Re: [Qemu-devel] [PATCH v5 0/3] DTC as submodule

[Paolo Bonzini <pbonzini@redhat.com>]

Il 18/04/2013 12:26, Edgar E. Iglesias ha scritto:
> On Thu, Apr 18, 2013 at 02:45:35PM +1000, peter.crosthwaite@xilinx.com wrote:
>> From: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
>>
>> These two patches add and use dtc as a submodule as per the RFC:
>>
>> http://lists.gnu.org/archive/html/qemu-devel/2013-01/msg05000.html
>>
>> There is a remaining action item to mandate libfdt for arm/microblaze and PPC
>> which is left as follow up work for after review of this series.
>>
>> Also fixed the configure to properly build pixman when cross compiling.
>>
>> changed since v4:
>> Use error_exit in configure
>> changed since v3:
>> Rebase against recent configure devls.
>> changed since v2:
>> Fixed P1 implementation (PMM review)
>> Fixed CC/AR/LD quoting issue P3 (PMM review)
>> Addressed PMM review
>> changed since v1:
>> Fixed cross compilation of submodules (new P1)
>> Fixed passing of ARFLAGS to dtc submake
> 
> 
> 
> Acked-by: Edgar E. Iglesias <edgar.iglesias@gmail.com>

Great, please apply!

> CC: Anthony and Bonzini
> 
> Shouldn't we in scripts/make_release have a stage that walks the submodules
> and makes sure to bootstrap autoconf so that we package release-tarballs
> with pre-generated configure scripts?
> IIUC, that is standard practice for autoconf tarball releases but I might
> be wrong.

It depends.  Some autoconfiscated packages put autoconf-generated
scripts in the repository.  In this case, there is no need to regenerate
the files when brewing the release.  Others leave out all such files
(including for example Bison-generated parsers); in this case of course
you need to include the scripts in the tarball, the user is not supposed
to run autoconf himself.

For submodules that do have autoconf-generated scripts in the repository
(I think both of them do, in our case), we should trust upstream's
configure script.  That's what everyone has been testing the git
repository with.

Paolo