From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:38518) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USpIm-0004RT-VO for qemu-devel@nongnu.org; Thu, 18 Apr 2013 09:55:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1USpIj-0003fU-Md for qemu-devel@nongnu.org; Thu, 18 Apr 2013 09:55:04 -0400 Received: from e9.ny.us.ibm.com ([32.97.182.139]:43612) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USpIj-0003br-G3 for qemu-devel@nongnu.org; Thu, 18 Apr 2013 09:55:01 -0400 Received: from /spool/local by e9.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 18 Apr 2013 09:54:59 -0400 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by d01dlp02.pok.ibm.com (Postfix) with ESMTP id 832C76E8055 for ; Thu, 18 Apr 2013 09:54:42 -0400 (EDT) Received: from d03av06.boulder.ibm.com (d03av06.boulder.ibm.com [9.17.195.245]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r3IDsaW8162044 for ; Thu, 18 Apr 2013 09:54:38 -0400 Received: from d03av06.boulder.ibm.com (loopback [127.0.0.1]) by d03av06.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r3IDvGxB014258 for ; Thu, 18 Apr 2013 07:57:16 -0600 Message-ID: <516FFB11.90505@linux.vnet.ibm.com> Date: Thu, 18 Apr 2013 09:54:25 -0400 From: "Michael R. Hines" MIME-Version: 1.0 References: <1366240040-10730-1-git-send-email-mrhines@linux.vnet.ibm.com> <1366240040-10730-9-git-send-email-mrhines@linux.vnet.ibm.com> <516FB285.2040701@redhat.com> In-Reply-To: <516FB285.2040701@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL v4 08/11] rdma: core logic List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Orit Wasserman Cc: aliguori@us.ibm.com, quintela@redhat.com, mst@redhat.com, qemu-devel@nongnu.org, abali@us.ibm.com, mrhines@us.ibm.com, gokul@us.ibm.com, pbonzini@redhat.com On 04/18/2013 04:44 AM, Orit Wasserman wrote: > Hi Michael, > > I don't see you addressed any of the comment I had in v3 > (especially the error handling) > > please, fix those I did fix them, but not all of your comments were correct, because I was passing errp in many places were errp did not supposed to belong there. So, first I *removed* errp from being proliferated all over the entire file, which was not necessary. Then, in the places where errp is required by migration.c, I added new uses of errp. There are some places, as Paolo mentioned where errp was written twice, which I must fix, however.