From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41296) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USpOq-0006k4-00 for qemu-devel@nongnu.org; Thu, 18 Apr 2013 10:01:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1USpOj-0006DT-DT for qemu-devel@nongnu.org; Thu, 18 Apr 2013 10:01:19 -0400 Received: from e32.co.us.ibm.com ([32.97.110.150]:59464) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USpOj-0006DC-5A for qemu-devel@nongnu.org; Thu, 18 Apr 2013 10:01:13 -0400 Received: from /spool/local by e32.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 18 Apr 2013 08:01:11 -0600 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by d03dlp01.boulder.ibm.com (Postfix) with ESMTP id 5FE37C40004 for ; Thu, 18 Apr 2013 07:54:53 -0600 (MDT) Received: from d03av06.boulder.ibm.com (d03av06.boulder.ibm.com [9.17.195.245]) by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r3IDxsDZ302168 for ; Thu, 18 Apr 2013 07:59:54 -0600 Received: from d03av06.boulder.ibm.com (loopback [127.0.0.1]) by d03av06.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r3IE2hes007564 for ; Thu, 18 Apr 2013 08:02:43 -0600 Message-ID: <516FFC58.8050303@linux.vnet.ibm.com> Date: Thu, 18 Apr 2013 09:59:52 -0400 From: "Michael R. Hines" MIME-Version: 1.0 References: <1366240040-10730-1-git-send-email-mrhines@linux.vnet.ibm.com> <1366240040-10730-9-git-send-email-mrhines@linux.vnet.ibm.com> <20130418075828.GA15869@redhat.com> In-Reply-To: <20130418075828.GA15869@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL v4 08/11] rdma: core logic List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: aliguori@us.ibm.com, quintela@redhat.com, qemu-devel@nongnu.org, owasserm@redhat.com, abali@us.ibm.com, mrhines@us.ibm.com, gokul@us.ibm.com, pbonzini@redhat.com On 04/18/2013 03:58 AM, Michael S. Tsirkin wrote: > The following comment applies to all of this code: > > On Wed, Apr 17, 2013 at 07:07:17PM -0400, mrhines@linux.vnet.ibm.com wrote: >> diff --git a/migration-rdma.c b/migration-rdma.c >> new file mode 100644 >> index 0000000..1dff06f >> --- /dev/null >> +++ b/migration-rdma.c >> @@ -0,0 +1,2667 @@ >> +/* >> + * Copyright (C) 2013 Michael R. Hines >> + * Copyright (C) 2010 Jiuxing Liu > By the way do you both really hold copyrights on this code? > It's not assigned to IBM? > If the later it should say: > Copyright IBM > Author: Michael R. Hines > Or some such. Acknowledged. >> + * >> + * RDMA protocol and interfaces >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License as published by >> + * the Free Software Foundation; under version 2 of the License. > > We prefer 2 or later for new code. Doesn't it say version 2 already? > I'm guessing you need approval from Jiuxing Liu for this, > pls make him ack license change. He approves. He doesn't work for IBM anymore.