From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52387) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USpwy-0006kx-JI for qemu-devel@nongnu.org; Thu, 18 Apr 2013 10:36:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1USpwv-0002fm-Oy for qemu-devel@nongnu.org; Thu, 18 Apr 2013 10:36:36 -0400 Received: from e9.ny.us.ibm.com ([32.97.182.139]:40377) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USpwv-0002fh-Kq for qemu-devel@nongnu.org; Thu, 18 Apr 2013 10:36:33 -0400 Received: from /spool/local by e9.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 18 Apr 2013 10:36:30 -0400 Received: from d01relay01.pok.ibm.com (d01relay01.pok.ibm.com [9.56.227.233]) by d01dlp02.pok.ibm.com (Postfix) with ESMTP id D837D6E8073 for ; Thu, 18 Apr 2013 10:36:17 -0400 (EDT) Received: from d01av05.pok.ibm.com (d01av05.pok.ibm.com [9.56.224.195]) by d01relay01.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r3IEaFjV132564 for ; Thu, 18 Apr 2013 10:36:15 -0400 Received: from d01av05.pok.ibm.com (loopback [127.0.0.1]) by d01av05.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r3IEaEhQ014042 for ; Thu, 18 Apr 2013 10:36:14 -0400 Message-ID: <517004DE.6040207@linux.vnet.ibm.com> Date: Thu, 18 Apr 2013 10:36:14 -0400 From: "Michael R. Hines" MIME-Version: 1.0 References: <1366240040-10730-1-git-send-email-mrhines@linux.vnet.ibm.com> <20130418070002.GB13787@redhat.com> In-Reply-To: <20130418070002.GB13787@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL v4 00/11] rdma: migration support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: aliguori@us.ibm.com, quintela@redhat.com, qemu-devel@nongnu.org, owasserm@redhat.com, abali@us.ibm.com, mrhines@us.ibm.com, gokul@us.ibm.com, pbonzini@redhat.com How about this one: /* * RDMA protocol and interfaces * * Copyright IBM, Corp. 2013 * * Authors: * Michael R. Hines * Jiuxing Liu * * This work is licensed under the terms of the GNU GPL, version 2. See * the COPYING file in the top-level directory. * * Contributions after 2012-01-13 are licensed under the terms of the * GNU GPL, version 2 or (at your option) any later version. */ Does this look OK? I just duplicated and hacked the one from Anthony in migration.c - Michael On 04/18/2013 03:00 AM, Michael S. Tsirkin wrote: > On Wed, Apr 17, 2013 at 07:07:09PM -0400, mrhines@linux.vnet.ibm.com wrote: >> From: "Michael R. Hines" >> >> The following changes since commit e0a83fc2c1582dc8d4453849852ebe6c258b7c3a: >> >> qom: do nothing on unparent of object without parent (2013-04-16 16:10:21 -0500) >> >> are available in the git repository at: >> >> git@github.com:hinesmr/qemu.git rdma_patch_v4 > It is customary to include performance numbers > showing the gain from the patch in the cover letter. > Github and wiki links are nice but don't require us > to chase this information please. > > >> for you to fetch changes up to 60bfc321613cd300af2ec0f7142e8ac1a5a8bdfd: >> >> rdma: add documentation (2013-04-17 19:04:32 -0400) > This is v4 and no changelog is provided. > This makes review very hard - we are supposed to > re-review everything. > > I looked at the documentation patch and not all of my > past comments on documentation were addressed. > Please address and log changes. > >> ---------------------------------------------------------------- >> Michael R. Hines (11): >> rdma: export yield_until_fd_readable() >> rdma: introduce qemu_ram_foreach_block() >> rdma: introduce qemu_file_mode_is_not_valid() >> rdma: export ram_handle_compressed() >> rdma: export qemu_fflush() >> rdma: new QEMUFileOps hooks >> rdma: introduce capability for chunk registration >> rdma: core logic >> rdma: send pc.ram >> rdma: print out throughput while debugging >> rdma: add documentation >> >> Makefile.objs | 1 + >> arch_init.c | 59 +- >> configure | 29 + >> docs/rdma.txt | 360 ++++++ >> exec.c | 9 + >> include/block/coroutine.h | 6 + >> include/exec/cpu-common.h | 5 + >> include/migration/migration.h | 23 + >> include/migration/qemu-file.h | 31 + >> migration-rdma.c | 2667 +++++++++++++++++++++++++++++++++++++++++ >> migration.c | 26 +- >> qapi-schema.json | 8 +- >> qemu-coroutine-io.c | 23 + >> savevm.c | 107 +- >> 14 files changed, 3305 insertions(+), 49 deletions(-) >> create mode 100644 docs/rdma.txt >> create mode 100644 migration-rdma.c >> -- >> 1.7.10.4