From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54637) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USq5Y-00038c-GO for qemu-devel@nongnu.org; Thu, 18 Apr 2013 10:45:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1USq5V-0005kj-Fj for qemu-devel@nongnu.org; Thu, 18 Apr 2013 10:45:28 -0400 Received: from e7.ny.us.ibm.com ([32.97.182.137]:45186) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USq5V-0005kc-BB for qemu-devel@nongnu.org; Thu, 18 Apr 2013 10:45:25 -0400 Received: from /spool/local by e7.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 18 Apr 2013 10:45:23 -0400 Received: from d01relay06.pok.ibm.com (d01relay06.pok.ibm.com [9.56.227.116]) by d01dlp02.pok.ibm.com (Postfix) with ESMTP id 6DF036E8062 for ; Thu, 18 Apr 2013 10:45:17 -0400 (EDT) Received: from d01av05.pok.ibm.com (d01av05.pok.ibm.com [9.56.224.195]) by d01relay06.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r3IEjKNL32636988 for ; Thu, 18 Apr 2013 10:45:20 -0400 Received: from d01av05.pok.ibm.com (loopback [127.0.0.1]) by d01av05.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r3IEjJOE028339 for ; Thu, 18 Apr 2013 10:45:19 -0400 Message-ID: <517006FF.6030202@linux.vnet.ibm.com> Date: Thu, 18 Apr 2013 10:45:19 -0400 From: "Michael R. Hines" MIME-Version: 1.0 References: <1366240040-10730-1-git-send-email-mrhines@linux.vnet.ibm.com> <1366240040-10730-9-git-send-email-mrhines@linux.vnet.ibm.com> <20130418075828.GA15869@redhat.com> <516FFC58.8050303@linux.vnet.ibm.com> <20130418130611.GA20196@redhat.com> <516FFFC3.1060701@linux.vnet.ibm.com> <20130418133232.GC20196@redhat.com> In-Reply-To: <20130418133232.GC20196@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL v4 08/11] rdma: core logic List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: aliguori@us.ibm.com, quintela@redhat.com, qemu-devel@nongnu.org, owasserm@redhat.com, abali@us.ibm.com, mrhines@us.ibm.com, gokul@us.ibm.com, pbonzini@redhat.com On 04/18/2013 09:32 AM, Michael S. Tsirkin wrote: > On Thu, Apr 18, 2013 at 10:14:27AM -0400, Michael R. Hines wrote: >> On 04/18/2013 09:06 AM, Michael S. Tsirkin wrote: >>> On Thu, Apr 18, 2013 at 09:59:52AM -0400, Michael R. Hines wrote: >>>> On 04/18/2013 03:58 AM, Michael S. Tsirkin wrote: >>>>> The following comment applies to all of this code: >>>>> >>>>> On Wed, Apr 17, 2013 at 07:07:17PM -0400, mrhines@linux.vnet.ibm.com wrote: >>>>>> diff --git a/migration-rdma.c b/migration-rdma.c >>>>>> new file mode 100644 >>>>>> index 0000000..1dff06f >>>>>> --- /dev/null >>>>>> +++ b/migration-rdma.c >>>>>> @@ -0,0 +1,2667 @@ >>>>>> +/* >>>>>> + * Copyright (C) 2013 Michael R. Hines >>>>>> + * Copyright (C) 2010 Jiuxing Liu >>>>> By the way do you both really hold copyrights on this code? >>>>> It's not assigned to IBM? >>>>> If the later it should say: >>>>> Copyright IBM >>>>> Author: Michael R. Hines >>>>> Or some such. >>>> Acknowledged. >>>> >>>>>> + * >>>>>> + * RDMA protocol and interfaces >>>>>> + * >>>>>> + * This program is free software; you can redistribute it and/or modify >>>>>> + * it under the terms of the GNU General Public License as published by >>>>>> + * the Free Software Foundation; under version 2 of the License. >>>>> We prefer 2 or later for new code. >>>> Doesn't it say version 2 already? >>> version 2 != 'version 2 or later'. See COPYING at the top level in qemu. >> I'll duplicate the copyright used in Anthony's migration.c and >> tailor it to match. > Sigh. Please don't copy migration.c, that includes a legacy header. > If you want to make things 2 or later, just take the > template from COPYING. There is a section 'How to Apply These Terms to > Your New Programs' there. It tells you exactly what to put in the code. > It's 2013 so if you want to be hip you can replace the FSF snail mail > address with " if not, see http://www.gnu.org/licenses/. " > which is a bit shorter. OK, I read the file, please review this version, and I will paste into migration-rdma.c: /* * RDMA Migration Protocol and Interfaces * * Copyright (C) 2013 Michael R. Hines * Copyright (C) 2010 Jiuxing Liu * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * * You should have received a copy of the GNU General Public License along * with this program; if not, write to the Free Software Foundation, Inc., * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ > >>>>> I'm guessing you need approval from Jiuxing Liu for this, >>>>> pls make him ack license change. >>>> He approves. He doesn't work for IBM anymore. >>> Does he approve version 2 or version 2 or later? >>> >> It doesn't matter - his contributions were made at IBM and he >> doesn't work for IBM anymore. > It's considered polite not to ignore author's wishes wrt licensing. > It's best to contact and get the ack if possible. If not, please tell > the list and we'll consider the options. > >