From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55525) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USwNQ-0000w5-D7 for qemu-devel@nongnu.org; Thu, 18 Apr 2013 17:28:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1USwNN-0006zQ-R5 for qemu-devel@nongnu.org; Thu, 18 Apr 2013 17:28:20 -0400 Received: from e7.ny.us.ibm.com ([32.97.182.137]:41741) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USwNN-0006zK-Mz for qemu-devel@nongnu.org; Thu, 18 Apr 2013 17:28:17 -0400 Received: from /spool/local by e7.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 18 Apr 2013 17:28:17 -0400 Received: from d01relay06.pok.ibm.com (d01relay06.pok.ibm.com [9.56.227.116]) by d01dlp02.pok.ibm.com (Postfix) with ESMTP id 5A9B96E803A for ; Thu, 18 Apr 2013 17:28:12 -0400 (EDT) Received: from d01av05.pok.ibm.com (d01av05.pok.ibm.com [9.56.224.195]) by d01relay06.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r3ILSFxg28770326 for ; Thu, 18 Apr 2013 17:28:15 -0400 Received: from d01av05.pok.ibm.com (loopback [127.0.0.1]) by d01av05.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r3ILSEcQ008812 for ; Thu, 18 Apr 2013 17:28:14 -0400 Message-ID: <5170656E.2020607@linux.vnet.ibm.com> Date: Thu, 18 Apr 2013 17:28:14 -0400 From: "Michael R. Hines" MIME-Version: 1.0 References: <1366240040-10730-1-git-send-email-mrhines@linux.vnet.ibm.com> <20130418070002.GB13787@redhat.com> <516FF9F1.7060703@linux.vnet.ibm.com> <20130418135011.GA20862@redhat.com> <517046D3.8020809@linux.vnet.ibm.com> <20130418201254.GB24094@redhat.com> In-Reply-To: <20130418201254.GB24094@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL v4 00/11] rdma: migration support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: aliguori@us.ibm.com, quintela@redhat.com, qemu-devel@nongnu.org, owasserm@redhat.com, abali@us.ibm.com, mrhines@us.ibm.com, gokul@us.ibm.com, pbonzini@redhat.com On 04/18/2013 04:12 PM, Michael S. Tsirkin wrote: > On Thu, Apr 18, 2013 at 03:17:39PM -0400, Michael R. Hines wrote: >> On 04/18/2013 09:50 AM, Michael S. Tsirkin wrote: >>> On Thu, Apr 18, 2013 at 09:49:37AM -0400, Michael R. Hines wrote: >>>> On 04/18/2013 03:00 AM, Michael S. Tsirkin wrote: >>>>> On Wed, Apr 17, 2013 at 07:07:09PM -0400, mrhines@linux.vnet.ibm.com wrote: >>>>>> From: "Michael R. Hines" >>>>>> >>>>>> The following changes since commit e0a83fc2c1582dc8d4453849852ebe6c258b7c3a: >>>>>> >>>>>> qom: do nothing on unparent of object without parent (2013-04-16 16:10:21 -0500) >>>>>> >>>>>> are available in the git repository at: >>>>>> >>>>>> git@github.com:hinesmr/qemu.git rdma_patch_v4 >>>>> It is customary to include performance numbers >>>>> showing the gain from the patch in the cover letter. >>>>> Github and wiki links are nice but don't require us >>>>> to chase this information please. >>>> Acknowledged. >>>> >>>>>> for you to fetch changes up to 60bfc321613cd300af2ec0f7142e8ac1a5a8bdfd: >>>>>> >>>>>> rdma: add documentation (2013-04-17 19:04:32 -0400) >>>>> This is v4 and no changelog is provided. >>>>> This makes review very hard - we are supposed to >>>>> re-review everything. >>>> Sorry - again I was scripting. I will stop scripting. >>>> >>>>> I looked at the documentation patch and not all of my >>>>> past comments on documentation were addressed. >>>>> Please address and log changes. >>>> I go very carefully through all of the reviews and make it a point >>>> to include all of the comments that were agreed upon. >>>> >>>> Exactly which comment did I forget? >>>> >>>> Thanks, >>>> - Michael >>> I tried to point some of them out in the mail I sent. >>> I think even if author does not agree with reviewer, it's often best to >>> partially address the review by adding comment in code or improving >>> documentation. If a reviewer was confused, so will the reader and the >>> user. >> I think the one I missed was "ulimit -l" + ibv_reg_mr() + cancel migration. >> >> I have a crappy description of this listed in TODO, but I can added >> it to the "Before Running" section. >> >> Would that be sufficient? > No, I listed other missing things. > You could be helpful by clearly pointing out whatever it is that you're concerned about. I'm not gonna go flip through every email of the last 200+ email exchanges. - Michael - Michael