From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40489) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USxAg-0006oV-D0 for qemu-devel@nongnu.org; Thu, 18 Apr 2013 18:19:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1USxAf-0007Jc-Bs for qemu-devel@nongnu.org; Thu, 18 Apr 2013 18:19:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:62822) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USx4d-0005mD-Ep for qemu-devel@nongnu.org; Thu, 18 Apr 2013 18:12:59 -0400 Message-ID: <51706FDA.3050609@redhat.com> Date: Thu, 18 Apr 2013 16:12:42 -0600 From: Eric Blake MIME-Version: 1.0 References: <1366240040-10730-1-git-send-email-mrhines@linux.vnet.ibm.com> <1366240040-10730-9-git-send-email-mrhines@linux.vnet.ibm.com> In-Reply-To: <1366240040-10730-9-git-send-email-mrhines@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2MFKCLJEWFCIOFKPAICTS" Subject: Re: [Qemu-devel] [PULL v4 08/11] rdma: core logic List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: mrhines@linux.vnet.ibm.com Cc: aliguori@us.ibm.com, quintela@redhat.com, mst@redhat.com, qemu-devel@nongnu.org, owasserm@redhat.com, abali@us.ibm.com, mrhines@us.ibm.com, gokul@us.ibm.com, pbonzini@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2MFKCLJEWFCIOFKPAICTS Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 04/17/2013 05:07 PM, mrhines@linux.vnet.ibm.com wrote: > From: "Michael R. Hines" >=20 > Code that does need to be visible is kept > well contained inside this file and this is the only > new additional file to the entire patch - good > progress. >=20 > This file includes the entire protocol and interfaces > required to perform RDMA migration. >=20 > Also, the configure and Makefile modifications to link > this file are included. >=20 > Full documentation is in docs/rdma.txt Which doesn't appear until later in the series? If a git bisect lands on this patch, I have to go out of my way to find the later commit that adds the docs. I personally like series that put the docs FIRST. On initial review, that gives the docs a chance for a clean-room review untainted by the implementation choices; and leaves the docs fresh in reviewers' minds during the rest of the series to validate that the implementation matches docs. On later review (such as git bisect landing here), it means the docs are in-tree for any other commit that references them. If it were me, I'd rebase things to put docs in patch 1 on the v5 series.= --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2MFKCLJEWFCIOFKPAICTS Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRcG/aAAoJEKeha0olJ0NqbdEIAKpNMgL2mbauDQwBHE/RePPx ZmXAgOH6qMtX0vkue4x33+GFMxgKMQdBTAq6Me4htcvC/6pEUvRKIOzXT2tbtzcj pi8yeWRS14bvqT/9R6N2Os8zW3zJYsW9dmcNsuLchR1c2MAckVEF/K4OSrNMtViL h3fTQ6rK4ciFXQBN0AJrNSBMJgL+J7El3QJr1vM7Muu0B4wfe0et5v1WB1eOArHW dcGlFhNd7z4CgptQHEfM2ueZW0pVrlrPfJw6cvTY3mdIUT/CdTU9kQfNfFZY5t3o CG+THMhIx4q5rQk/MMW8c5Ng6Rx2vHr/t+LO6bQfqDLdrqsuBZlklR8dhRptz7A= =uor5 -----END PGP SIGNATURE----- ------enig2MFKCLJEWFCIOFKPAICTS--