From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:38553) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USzJ1-0008AJ-LP for qemu-devel@nongnu.org; Thu, 18 Apr 2013 20:36:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1USzIx-000870-Rj for qemu-devel@nongnu.org; Thu, 18 Apr 2013 20:35:59 -0400 Received: from e37.co.us.ibm.com ([32.97.110.158]:47785) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USzIx-00086q-LH for qemu-devel@nongnu.org; Thu, 18 Apr 2013 20:35:55 -0400 Received: from /spool/local by e37.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 18 Apr 2013 18:35:54 -0600 Received: from d03relay03.boulder.ibm.com (d03relay03.boulder.ibm.com [9.17.195.228]) by d03dlp01.boulder.ibm.com (Postfix) with ESMTP id 83E671FF0044 for ; Thu, 18 Apr 2013 18:30:40 -0600 (MDT) Received: from d03av06.boulder.ibm.com (d03av06.boulder.ibm.com [9.17.195.245]) by d03relay03.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r3J0ZfxH119684 for ; Thu, 18 Apr 2013 18:35:41 -0600 Received: from d03av06.boulder.ibm.com (loopback [127.0.0.1]) by d03av06.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r3J0cVf2007929 for ; Thu, 18 Apr 2013 18:38:31 -0600 Message-ID: <5170915A.8050907@linux.vnet.ibm.com> Date: Thu, 18 Apr 2013 20:35:38 -0400 From: "Michael R. Hines" MIME-Version: 1.0 References: <1366240040-10730-1-git-send-email-mrhines@linux.vnet.ibm.com> <1366240040-10730-9-git-send-email-mrhines@linux.vnet.ibm.com> <51706FDA.3050609@redhat.com> In-Reply-To: <51706FDA.3050609@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL v4 08/11] rdma: core logic List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: aliguori@us.ibm.com, mst@redhat.com, quintela@redhat.com, qemu-devel@nongnu.org, owasserm@redhat.com, abali@us.ibm.com, mrhines@us.ibm.com, gokul@us.ibm.com, pbonzini@redhat.com On 04/18/2013 06:12 PM, Eric Blake wrote: > On 04/17/2013 05:07 PM, mrhines@linux.vnet.ibm.com wrote: >> From: "Michael R. Hines" >> >> Code that does need to be visible is kept >> well contained inside this file and this is the only >> new additional file to the entire patch - good >> progress. >> >> This file includes the entire protocol and interfaces >> required to perform RDMA migration. >> >> Also, the configure and Makefile modifications to link >> this file are included. >> >> Full documentation is in docs/rdma.txt > Which doesn't appear until later in the series? If a git bisect lands > on this patch, I have to go out of my way to find the later commit that > adds the docs. > > I personally like series that put the docs FIRST. On initial review, > that gives the docs a chance for a clean-room review untainted by the > implementation choices; and leaves the docs fresh in reviewers' minds > during the rest of the series to validate that the implementation > matches docs. On later review (such as git bisect landing here), it > means the docs are in-tree for any other commit that references them. > If it were me, I'd rebase things to put docs in patch 1 on the v5 series. > No problem. Will do.