From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42365) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UT63u-0003kp-PI for qemu-devel@nongnu.org; Fri, 19 Apr 2013 03:48:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UT63r-000113-Uj for qemu-devel@nongnu.org; Fri, 19 Apr 2013 03:48:50 -0400 Received: from mail-ee0-f53.google.com ([74.125.83.53]:60490) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UT63r-00010V-OR for qemu-devel@nongnu.org; Fri, 19 Apr 2013 03:48:47 -0400 Received: by mail-ee0-f53.google.com with SMTP id d17so932769eek.26 for ; Fri, 19 Apr 2013 00:48:46 -0700 (PDT) Sender: Richard Henderson Message-ID: <5170F6D3.4020006@twiddle.net> Date: Fri, 19 Apr 2013 09:48:35 +0200 From: Richard Henderson MIME-Version: 1.0 References: <1366339945-17151-1-git-send-email-lig.fnst@cn.fujitsu.com> <1366339945-17151-2-git-send-email-lig.fnst@cn.fujitsu.com> In-Reply-To: <1366339945-17151-2-git-send-email-lig.fnst@cn.fujitsu.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/6] target-i386/seg_helper: replace env->eip with EIP List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: liguang Cc: peter.maydell@linaro.org, aliguori@us.ibm.com, qemu-devel@nongnu.org, blauwirbel@gmail.com, pbonzini@redhat.com, afaerber@suse.de On 2013-04-19 04:52, liguang wrote: > Signed-off-by: liguang > --- > target-i386/seg_helper.c | 46 +++++++++++++++++++++++----------------------- > 1 files changed, 23 insertions(+), 23 deletions(-) > > diff --git a/target-i386/seg_helper.c b/target-i386/seg_helper.c > index 906e4f3..5f7f99d 100644 > --- a/target-i386/seg_helper.c > +++ b/target-i386/seg_helper.c > @@ -388,7 +388,7 @@ static void switch_tss(CPUX86State *env, int tss_selector, > > /* load all registers without an exception, then reload them with > possible exception */ > - env->eip = new_eip; > + EIP = new_eip; IMO this is not a cleanup, and we should in fact be doing the exact opposite, getting rid of those silly macros. r~