From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:58424)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1UTALM-0007yV-Fk
	for qemu-devel@nongnu.org; Fri, 19 Apr 2013 08:23:10 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1UTALJ-0002Lb-QP
	for qemu-devel@nongnu.org; Fri, 19 Apr 2013 08:23:08 -0400
Received: from mx1.redhat.com ([209.132.183.28]:8707)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1UTALJ-0002LO-H9
	for qemu-devel@nongnu.org; Fri, 19 Apr 2013 08:23:05 -0400
Message-ID: <51713715.4010908@redhat.com>
Date: Fri, 19 Apr 2013 06:22:45 -0600
From: Eric Blake <eblake@redhat.com>
MIME-Version: 1.0
References: <1366365123-5412-1-git-send-email-akong@redhat.com>
	<51713241.70403@redhat.com>
In-Reply-To: <51713241.70403@redhat.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature";
	boundary="----enig2ETWNEHMKRGBDJIKDHRXM"
Subject: Re: [Qemu-devel] [PATCH] monitor: introduce query-config-schema
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Osier Yang <jyang@redhat.com>
Cc: lcapitulino@redhat.com, aliguori@us.ibm.com, Amos Kong <akong@redhat.com>, mdroth@linux.vnet.ibm.com, qemu-devel@nongnu.org

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
------enig2ETWNEHMKRGBDJIKDHRXM
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On 04/19/2013 06:02 AM, Osier Yang wrote:
> On 19/04/13 17:52, Amos Kong wrote:
>> Libvirt doesn't have a stable way to know option support
>=20
> Actually no way now.
>=20

>> +
>> +##
>> +# @ConfigSchemaInfo:
>> +#
>> +# Configration schema information.
>> +#
>> +# @option: option name
>> +#
>> +# @config-schema: configuration schema string of one option
>=20
> Since if no option name is  specified, all the config schema is
> returned, you
> might want to change this comment a bit.

No, this part is correct.  This is an intermediate type for one option,
then the QMP command returns an array of these types.

>=20
>> +#
>> +# Since 1.5
>> +##
>> +{ 'type': 'ConfigSchemaInfo', 'data': {'option': 'str',
>> 'config-schema': 'str'} }
>> +
>> +##
>> +# @query-config-schema
>> +#
>> +# Query configuration schema information of options
>=20
> And this.

But here, it might make sense to call out that the default is all
options, but specifying a name limits to one option.

--=20
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


------enig2ETWNEHMKRGBDJIKDHRXM
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.13 (GNU/Linux)
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCAAGBQJRcTcVAAoJEKeha0olJ0NqQecH/jQr6AwI4MOJLHQ8VRAACQwN
7assacF/9F5VW8tdSiASmjCk0HaoJzwKOgwoqSTAYc2DqMczAy9x57px9fqW67VC
FDbl6etLLxEDMNInzIoT0iWvd5nDfEzPIsO25mJZaJWN1tOGb27FZB1bY0OxqX/Z
qPbDBqvFpUPx06qGPUZXhKMtQA9pwfR7PUVVRDfDy6mbzXYyKETgut1VMVKCBPBO
jCsGtaPGKMuhDgR5qop2feB4WHmw4Ht88+IrLv6tqgMe/xrKESlQY3DBfsooi9QT
6YsAo/fSjUp02Wh/weqvW4xXiasdXmVI4xWZpwPhbvZqv8a8SOmyrx+0QUVLs5w=
=ooNj
-----END PGP SIGNATURE-----

------enig2ETWNEHMKRGBDJIKDHRXM--