From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: Max Reitz <mreitz@redhat.com>, qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Juan Quintela <quintela@redhat.com>,
Peter Krempa <pkrempa@redhat.com>,
qemu-devel@nongnu.org,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [PATCH 2/4] migration: Add block-bitmap-mapping parameter
Date: Thu, 2 Jul 2020 13:49:23 +0300 [thread overview]
Message-ID: <5171e8a2-0cf0-d8db-4dd1-0138fe2b15f5@virtuozzo.com> (raw)
In-Reply-To: <889082d7-c917-ba7c-6da3-e854d8c44a32@redhat.com>
02.07.2020 12:41, Max Reitz wrote:
>>> I don’t know if doing it differently would actually be beneficial for
>>> anyone, but OTOH naively it seems like a more invasive code change.
>>>
>> I don't see real benefits, we can go either way, so, not worth rewriting
>> the patch.
>>
>> ===
>>
>> I feel like a stupid reviewer:)
> Huh? If anything, a stupid review on a design-changing patch would be a
> plain “R-b” without having actually considered the impact. You do
> consider the impact and question it in all places.
>
> I don’t think I need to mention this, but that’s a very good and
> important thing to do, because it forces me to reason why we’d want this
> or that design. Without being questioned, I wouldn’t have to reason
> about that. (Which may be a problem in our patch workflow – authors
> don’t need to reason unless questioned.[1])
>
> Sorry if I gave the impression of dismissing your comments. It should
> be my burden to reason why I took certain design decisions.
No problem. I should better describe reasons for my suggestions as well, or
if I have no one, mark it as "thinking-out-loud" instead of recommended change.
--
Best regards,
Vladimir
next prev parent reply other threads:[~2020-07-02 10:50 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-30 8:45 [PATCH 0/4] migration: Add block-bitmap-mapping parameter Max Reitz
2020-06-30 8:45 ` [PATCH 1/4] migration: Prevent memleak by ...params_test_apply Max Reitz
2020-06-30 10:28 ` Dr. David Alan Gilbert
2020-07-01 11:10 ` Vladimir Sementsov-Ogievskiy
2020-07-01 14:38 ` Eric Blake
2020-07-02 8:14 ` Max Reitz
2020-06-30 8:45 ` [PATCH 2/4] migration: Add block-bitmap-mapping parameter Max Reitz
2020-06-30 10:51 ` Dr. David Alan Gilbert
2020-07-01 10:34 ` Max Reitz
2020-07-02 11:22 ` Dr. David Alan Gilbert
2020-07-01 14:34 ` Vladimir Sementsov-Ogievskiy
2020-07-02 8:09 ` Max Reitz
2020-07-02 9:19 ` Vladimir Sementsov-Ogievskiy
2020-07-02 9:41 ` Max Reitz
2020-07-02 10:40 ` Vladimir Sementsov-Ogievskiy
2020-07-02 10:49 ` Vladimir Sementsov-Ogievskiy [this message]
2020-07-02 13:04 ` Vladimir Sementsov-Ogievskiy
2020-06-30 8:45 ` [PATCH 3/4] iotests.py: Add wait_for_runstate() Max Reitz
2020-06-30 8:45 ` [PATCH 4/4] iotests: Test node/bitmap aliases during migration Max Reitz
2020-07-02 11:24 ` [PATCH 0/4] migration: Add block-bitmap-mapping parameter Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5171e8a2-0cf0-d8db-4dd1-0138fe2b15f5@virtuozzo.com \
--to=vsementsov@virtuozzo.com \
--cc=dgilbert@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pkrempa@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).