Re: [Qemu-devel] [PATCH] monitor: intervally send down events to guest in hold time

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1263 bytes --]

On 04/18/2013 10:44 PM, Amos Kong wrote:
> (qemu) sendkey a 1000
> 
> Current design is that qemu only send one down event to guest,
> and delay sometime, then send one up event. In this case, only
> key can be identified by guest.
> 
> This patch changed qemu to intervally send down events to guest
> in the hold time, the interval is 100ms.

I don't like this.  When you hold a key for a long time on bare metal,
there is only one down and one up event; if the console displays
multiple copies of the character being typed, it is because the console
does the repeats itself.  If the user wants multiple down and up events,
they should send multiple events, not rely on one command to send
multiple presses.

> 
> (qemu) sendkey a 1000
> 
> qemu will send 9 down events, 1 up event to guest, we can see
> 9 'a' in guest screen.


I'm inclined to NACK this unless you can give better explanation why
send-key should behave differently than bare metal.  If anything, the
behavior being complained about is a "feature" of the console of the
guest being tested, not something where we should change how the
hardware behaves.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]