From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37076) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UTaJ8-0008HS-8n for qemu-devel@nongnu.org; Sat, 20 Apr 2013 12:06:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UTaJ5-00087A-JI for qemu-devel@nongnu.org; Sat, 20 Apr 2013 12:06:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58344) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UTaJ5-00086o-Ae for qemu-devel@nongnu.org; Sat, 20 Apr 2013 12:06:31 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r3KG6TFE019594 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sat, 20 Apr 2013 12:06:30 -0400 Message-ID: <5172BD04.2050504@redhat.com> Date: Sat, 20 Apr 2013 10:06:28 -0600 From: Eric Blake MIME-Version: 1.0 References: <1366346658-4680-1-git-send-email-akong@redhat.com> In-Reply-To: <1366346658-4680-1-git-send-email-akong@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2JHTLRXVMCPKEASJXKSHX" Subject: Re: [Qemu-devel] [PATCH] monitor: intervally send down events to guest in hold time List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amos Kong Cc: kraxel@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2JHTLRXVMCPKEASJXKSHX Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 04/18/2013 10:44 PM, Amos Kong wrote: > (qemu) sendkey a 1000 >=20 > Current design is that qemu only send one down event to guest, > and delay sometime, then send one up event. In this case, only > key can be identified by guest. >=20 > This patch changed qemu to intervally send down events to guest > in the hold time, the interval is 100ms. I don't like this. When you hold a key for a long time on bare metal, there is only one down and one up event; if the console displays multiple copies of the character being typed, it is because the console does the repeats itself. If the user wants multiple down and up events, they should send multiple events, not rely on one command to send multiple presses. >=20 > (qemu) sendkey a 1000 >=20 > qemu will send 9 down events, 1 up event to guest, we can see > 9 'a' in guest screen. I'm inclined to NACK this unless you can give better explanation why send-key should behave differently than bare metal. If anything, the behavior being complained about is a "feature" of the console of the guest being tested, not something where we should change how the hardware behaves. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2JHTLRXVMCPKEASJXKSHX Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRcr0EAAoJEKeha0olJ0Nq510H/3VAwmexsBeodQa3CH9fNbWL qoTPyFyhYSCNdrBpOv73305Du9Qi75zOkG3JdNJwKViFnQWnDnZSexlyUp4YuRNb 8uhHnUEL2uOI5+Glq1CDJWxaMpYX/E2igDhjVBPElq9cy25sMFSEAw3WTlgnS670 6W4pMxYYE1fGSlGInaF77QVoA0VetjQYxdqES65wPG7Xi6txbbU9wzQV/kUtcL/h QLjIpVcdt8Ug/iBavt0VC0m4iRhU5VaLOIAnDsWYOvd4ulCbQWuFVw35ekTcd6Op /DfwAaWBCN3oOA5C+QRS0S3481tjn8itE2esiDVtmIEw/AiEHe1MxWdwq/I7S3I= =jGFL -----END PGP SIGNATURE----- ------enig2JHTLRXVMCPKEASJXKSHX--