From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:48678) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UTb90-00015T-F4 for qemu-devel@nongnu.org; Sat, 20 Apr 2013 13:00:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UTb8w-0000bB-HB for qemu-devel@nongnu.org; Sat, 20 Apr 2013 13:00:10 -0400 Received: from mail-we0-x22e.google.com ([2a00:1450:400c:c03::22e]:61199) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UTb8w-0000Yk-Bf for qemu-devel@nongnu.org; Sat, 20 Apr 2013 13:00:06 -0400 Received: by mail-we0-f174.google.com with SMTP id u12so4687347wey.19 for ; Sat, 20 Apr 2013 10:00:04 -0700 (PDT) Sender: Richard Henderson Message-ID: <5172C992.8010107@twiddle.net> Date: Sat, 20 Apr 2013 10:00:02 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1366360066-3373-1-git-send-email-rth@twiddle.net> <51713463.4080300@suse.de> <51713624.8050502@suse.de> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH] tcg: Remove temp_buf List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , Aurelien Jarno , qemu-devel On 04/20/2013 03:46 AM, Blue Swirl wrote: > On Fri, Apr 19, 2013 at 12:18 PM, Andreas Färber wrote: >> Am 19.04.2013 14:11, schrieb Andreas Färber: >>> Hi, >>> >>> Am 19.04.2013 10:27, schrieb Richard Henderson: >>>> All targets have been converted to allocating space for temporaries >>>> on the stack. No need to allocate space within the CPU_COMMON block. >>>> >>>> Signed-off-by: Richard Henderson >>>> --- >>>> This depends on my tcg-arm patch set that's still outstanding. >>> My tree still has exactly one user in tcg/arm/, so once that disappears >>> feel free to add my Reviewed-by. Thanks for helping clean this up! >>> >>> One question... >>> >>>> >>>> r~ >>>> --- >>>> include/exec/cpu-defs.h | 2 -- >>>> 1 file changed, 2 deletions(-) >>>> >>>> diff --git a/include/exec/cpu-defs.h b/include/exec/cpu-defs.h >>>> index d8c64e9..41f5b32 100644 >>>> --- a/include/exec/cpu-defs.h >>>> +++ b/include/exec/cpu-defs.h >>>> @@ -152,8 +152,6 @@ typedef struct CPUWatchpoint { >>>> memory was accessed */ \ >>>> CPU_COMMON_TLB \ >>>> struct TranslationBlock *tb_jmp_cache[TB_JMP_CACHE_SIZE]; \ >>>> - /* buffer for temporaries in the code generator */ \ >>>> - long temp_buf[CPU_TEMP_BUF_NLONGS]; \ >>> Could CPU_TEMP_BUF_NLONGS be removed, too? >> More precisely, seeing that all targets actually still use it despite in >> most cases not actually accessing temp_buf, can you rename it to >> TCG_TEMP_STACK_NLONGS and move it to some TCG header as a follow-up please? > Much like this patch? > > http://lists.nongnu.org/archive/html/qemu-devel/2011-05/msg03086.html > Yes, that would be the one... r~