From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:60203)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1UTu7w-00056Q-G0
	for qemu-devel@nongnu.org; Sun, 21 Apr 2013 09:16:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1UTu7v-00060N-OO
	for qemu-devel@nongnu.org; Sun, 21 Apr 2013 09:16:20 -0400
Received: from mail-we0-x231.google.com ([2a00:1450:400c:c03::231]:47460)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1UTu7v-00060A-IO
	for qemu-devel@nongnu.org; Sun, 21 Apr 2013 09:16:19 -0400
Received: by mail-we0-f177.google.com with SMTP id t49so248803wey.8
	for <qemu-devel@nongnu.org>; Sun, 21 Apr 2013 06:16:18 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <5173E697.4050606@redhat.com>
Date: Sun, 21 Apr 2013 15:16:07 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <cover.1366260005.git.peter.crosthwaite@xilinx.com>
	<d990882bb4317e4d8d784e6e296d45d3b27ee236.1366260005.git.peter.crosthwaite@xilinx.com>
	<CAAu8pHvhB97aO4_-nJfvOn1yk5UqgKPkzCB6JaWR0O+Sh9Z_Ng@mail.gmail.com>
In-Reply-To: <CAAu8pHvhB97aO4_-nJfvOn1yk5UqgKPkzCB6JaWR0O+Sh9Z_Ng@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v5 3/3] configure/Make: Build libfdt from
	submodule DTC
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, Peter Crosthwaite <peter.crosthwaite@xilinx.com>, qemu-devel <qemu-devel@nongnu.org>, Peter Maydell <peter.maydell@linaro.org>

Il 20/04/2013 20:42, Blue Swirl ha scritto:
> This is not entirely correct, I get these errors:
> mingw32:
>      CC libfdt/fdt.o
> cc1: warnings being treated as errors
> /src/qemu/dtc/libfdt/fdt.c:1: warning: -fPIC ignored for target (all
> code is position independent)
> 
> Other flags, including -fPIC, is missing for Clang:
>      LD libfdt/libfdt-1.3.0.so
> /usr/bin/ld: libfdt/fdt.o: relocation R_X86_64_32S against `.rodata'
> can not be used when making a shared object; recompile with -fPIC
> 
> My build script also passes additional CFLAGS to both.
> 
> Perhaps the fix is to use QEMU_CFLAGS instead of (or in addition to)
> CFLAGS above for DTC_CFLAGS? Or add -fPIC as with pixman?

libfdt is not that portable, it doesn't use libtool to build shared
libraries.

Perhaps we can just build the static library?

Paolo