From: Paolo Bonzini <pbonzini@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: aliguori@us.ibm.com, quintela@redhat.com, qemu-devel@nongnu.org,
mrhines@linux.vnet.ibm.com, owasserm@redhat.com,
abali@us.ibm.com, mrhines@us.ibm.com, gokul@us.ibm.com
Subject: Re: [Qemu-devel] [PULL v4 07/11] rdma: introduce capability for chunk registration
Date: Sun, 21 Apr 2013 15:19:21 +0200 [thread overview]
Message-ID: <5173E759.5080906@redhat.com> (raw)
In-Reply-To: <20130420170240.GA16115@redhat.com>
Il 20/04/2013 19:02, Michael S. Tsirkin ha scritto:
>> > I guess the opposite sense could be named 'x-rdma-pin-all'; default
>> > false means to do chunk registration and release,
> chunk release only happens after migration is complete unfortunately.
> This means that eventually all initialized memory is pinned, regardless
> of the setting (this is fixable but there's no plan to fix this, at this
> point). So pin-all might be misleading to some.
>
> I agree 'chunk' is unnecessarily low level though.
> The only difference ATM is pinning of uninitialized memory so I think a
> better name would be 'x-rdma-pin-uninitialized' or some such.
>
x-rdma-pin-all is a better choice. x-rdma-pin-uninitialized is also too
low level.
Since this series is likely to miss 1.5 at this point, we could
implement the unregistration part of the protocol in the destination.
This way, any heuristic we add to the source will not break backwards
compatibility.
Paolo
next prev parent reply other threads:[~2013-04-21 13:19 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-17 23:07 [Qemu-devel] [PULL v4 00/11] rdma: migration support mrhines
2013-04-17 23:07 ` [Qemu-devel] [PULL v4 01/11] rdma: export yield_until_fd_readable() mrhines
2013-04-17 23:07 ` [Qemu-devel] [PULL v4 02/11] rdma: introduce qemu_ram_foreach_block() mrhines
2013-04-17 23:07 ` [Qemu-devel] [PULL v4 03/11] rdma: introduce qemu_file_mode_is_not_valid() mrhines
2013-04-17 23:07 ` [Qemu-devel] [PULL v4 04/11] rdma: export ram_handle_compressed() mrhines
2013-04-17 23:07 ` [Qemu-devel] [PULL v4 05/11] rdma: export qemu_fflush() mrhines
2013-04-17 23:07 ` [Qemu-devel] [PULL v4 06/11] rdma: new QEMUFileOps hooks mrhines
2013-04-17 23:07 ` [Qemu-devel] [PULL v4 07/11] rdma: introduce capability for chunk registration mrhines
2013-04-18 22:07 ` Eric Blake
2013-04-19 0:34 ` Michael R. Hines
2013-04-20 17:02 ` Michael S. Tsirkin
2013-04-21 13:19 ` Paolo Bonzini [this message]
2013-04-21 14:17 ` Michael S. Tsirkin
2013-04-21 17:19 ` Michael R. Hines
2013-04-21 19:13 ` Michael S. Tsirkin
2013-04-21 16:05 ` Michael R. Hines
2013-04-21 18:59 ` Michael S. Tsirkin
2013-04-21 19:55 ` Michael R. Hines
2013-04-21 16:06 ` Michael R. Hines
2013-04-17 23:07 ` [Qemu-devel] [PULL v4 08/11] rdma: core logic mrhines
2013-04-18 7:55 ` Paolo Bonzini
2013-04-18 13:57 ` Michael R. Hines
2013-04-18 7:58 ` Michael S. Tsirkin
2013-04-18 13:59 ` Michael R. Hines
2013-04-18 13:06 ` Michael S. Tsirkin
2013-04-18 14:14 ` Michael R. Hines
2013-04-18 13:32 ` Michael S. Tsirkin
2013-04-18 14:45 ` Michael R. Hines
2013-04-18 13:52 ` Michael S. Tsirkin
2013-04-18 15:14 ` Anthony Liguori
2013-04-18 14:53 ` [Qemu-devel] licensing of IBM contributions to QEMU (was Re: [PULL v4 08/11] rdma: core logic) Paolo Bonzini
2013-04-18 19:15 ` Michael R. Hines
2013-04-19 0:35 ` Anthony Liguori
2013-04-18 8:44 ` [Qemu-devel] [PULL v4 08/11] rdma: core logic Orit Wasserman
2013-04-18 13:54 ` Michael R. Hines
2013-04-18 15:51 ` Orit Wasserman
2013-04-18 19:41 ` Michael R. Hines
2013-04-18 22:12 ` Eric Blake
2013-04-19 0:35 ` Michael R. Hines
2013-04-17 23:07 ` [Qemu-devel] [PULL v4 09/11] rdma: send pc.ram mrhines
2013-04-17 23:07 ` [Qemu-devel] [PULL v4 10/11] rdma: print out throughput while debugging mrhines
2013-04-17 23:07 ` [Qemu-devel] [PULL v4 11/11] rdma: add documentation mrhines
2013-04-18 6:55 ` Michael S. Tsirkin
2013-04-19 0:57 ` Michael R. Hines
2013-04-17 23:39 ` [Qemu-devel] [PULL v4 00/11] rdma: migration support Anthony Liguori
2013-04-18 13:46 ` Michael R. Hines
2013-04-18 7:00 ` Michael S. Tsirkin
2013-04-18 13:49 ` Michael R. Hines
2013-04-18 13:50 ` Michael S. Tsirkin
2013-04-18 19:17 ` Michael R. Hines
2013-04-18 20:12 ` Michael S. Tsirkin
2013-04-18 21:28 ` Michael R. Hines
2013-04-18 20:33 ` Michael S. Tsirkin
2013-04-18 14:36 ` Michael R. Hines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5173E759.5080906@redhat.com \
--to=pbonzini@redhat.com \
--cc=abali@us.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=gokul@us.ibm.com \
--cc=mrhines@linux.vnet.ibm.com \
--cc=mrhines@us.ibm.com \
--cc=mst@redhat.com \
--cc=owasserm@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).