From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60733) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UTuB5-0006Af-JZ for qemu-devel@nongnu.org; Sun, 21 Apr 2013 09:19:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UTuB2-0006pq-N3 for qemu-devel@nongnu.org; Sun, 21 Apr 2013 09:19:35 -0400 Received: from mail-we0-x22e.google.com ([2a00:1450:400c:c03::22e]:58277) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UTuB2-0006oG-FL for qemu-devel@nongnu.org; Sun, 21 Apr 2013 09:19:32 -0400 Received: by mail-we0-f174.google.com with SMTP id u12so5224281wey.19 for ; Sun, 21 Apr 2013 06:19:31 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <5173E759.5080906@redhat.com> Date: Sun, 21 Apr 2013 15:19:21 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1366240040-10730-1-git-send-email-mrhines@linux.vnet.ibm.com> <1366240040-10730-8-git-send-email-mrhines@linux.vnet.ibm.com> <51706E9C.9@redhat.com> <20130420170240.GA16115@redhat.com> In-Reply-To: <20130420170240.GA16115@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL v4 07/11] rdma: introduce capability for chunk registration List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: aliguori@us.ibm.com, quintela@redhat.com, qemu-devel@nongnu.org, mrhines@linux.vnet.ibm.com, owasserm@redhat.com, abali@us.ibm.com, mrhines@us.ibm.com, gokul@us.ibm.com Il 20/04/2013 19:02, Michael S. Tsirkin ha scritto: >> > I guess the opposite sense could be named 'x-rdma-pin-all'; default >> > false means to do chunk registration and release, > chunk release only happens after migration is complete unfortunately. > This means that eventually all initialized memory is pinned, regardless > of the setting (this is fixable but there's no plan to fix this, at this > point). So pin-all might be misleading to some. > > I agree 'chunk' is unnecessarily low level though. > The only difference ATM is pinning of uninitialized memory so I think a > better name would be 'x-rdma-pin-uninitialized' or some such. > x-rdma-pin-all is a better choice. x-rdma-pin-uninitialized is also too low level. Since this series is likely to miss 1.5 at this point, we could implement the unregistration part of the protocol in the destination. This way, any heuristic we add to the source will not break backwards compatibility. Paolo